Issue 7104074: Attempt at fixing crash. It looks like the printing code can delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104074: Attempt at fixing crash. It looks like the printing code can delete (Closed)

Created:
9 years, 6 months ago by sky

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Attempt at fixing crash. It looks like the printing code can delete the TabContents, not the TabContentsWrapper, which leaves the TabContentsWrapper (and its associated helper classes) with references to a deleted TabContents. BUG=85455 TEST=none R=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88582

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -16 lines)			Patch
M	chrome/browser/printing/background_printing_manager.cc	View		2 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	1 2	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/notification_type.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

sky

I believe this is at least one reason the bookmarks code could be crashing. I ...

9 years, 6 months ago (2011-06-09 15:08:24 UTC) #1

LGTM