Issue 7104067: Make PanelBrowserView derive from NativePanel. Also add some more methods to NativePanel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104067: Make PanelBrowserView derive from NativePanel. Also add some more methods to NativePanel. (Closed)

Created:
9 years, 6 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
jennb

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make PanelBrowserView derive from NativePanel. Also add some more methods to NativePanel. BUG=none TEST=existing tests due to no new functionaility Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88441

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -7 lines)			Patch
M	chrome/browser/ui/panels/native_panel.h	View	1	2 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.h	View		3 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.cc	View		1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennb

http://codereview.chromium.org/7104067/diff/1004/chrome/browser/ui/panels/native_panel.h File chrome/browser/ui/panels/native_panel.h (right): http://codereview.chromium.org/7104067/diff/1004/chrome/browser/ui/panels/native_panel.h#newcode26 chrome/browser/ui/panels/native_panel.h:26: public: Should we make all these methods protected and ...

9 years, 6 months ago (2011-06-08 21:14:08 UTC) #2

jianli

9 years, 6 months ago (2011-06-08 21:38:10 UTC) #3

LGTM

Expand Messages | Collapse Messages