Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 7104065: [NTP] Fix identification of the web store app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 745d6bc27b8d2a41ba6972d6d3ea2421b84511a7..633faf7d6ca8aff3c54b44a91aa41b7f0e8b84fe 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -50,8 +50,6 @@ const char* kPingLaunchAppByID = "record-app-launch-by-id";
const char* kPingLaunchWebStore = "record-webstore-launch";
const char* kPingLaunchAppByURL = "record-app-launch-by-url";
-const char* kChromeWebStoreUrl = "https://chrome.google.com/webstore/";
-
const UnescapeRule::Type kUnescapeRules =
UnescapeRule::NORMAL | UnescapeRule::URL_SPECIAL_CHARS;
@@ -231,7 +229,7 @@ void AppLauncherHandler::FillAppDictionary(DictionaryValue* dictionary) {
// Don't include the WebStore.
// The WebStore launcher gets special treatment in ntp/apps.js.
if ((*it)->is_app() &&
- (*it)->GetFullLaunchURL().spec() != kChromeWebStoreUrl) {
+ (*it)->id() != extension_misc::kWebStoreAppId) {
DictionaryValue* app_info = new DictionaryValue();
CreateAppInfo(*it, extensions_service_->extension_prefs(), app_info);
list->Append(app_info);
@@ -241,7 +239,7 @@ void AppLauncherHandler::FillAppDictionary(DictionaryValue* dictionary) {
extensions = extensions_service_->disabled_extensions();
for (it = extensions->begin(); it != extensions->end(); ++it) {
if ((*it)->is_app() &&
- (*it)->GetFullLaunchURL().spec() != kChromeWebStoreUrl) {
+ (*it)->id() != extension_misc::kWebStoreAppId) {
DictionaryValue* app_info = new DictionaryValue();
CreateAppInfo(*it, extensions_service_->extension_prefs(), app_info);
list->Append(app_info);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698