Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 7104062: clang: Let release builds use -O3, like on gcc. (Closed)

Created:
9 years, 6 months ago by Nico
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

clang: Let release builds use -O3, like on gcc. Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully no longer crash clang. BUG=84815 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Since there are no release clang trybots, I can't test this before checking in (well, ...
9 years, 6 months ago (2011-06-08 19:52:41 UTC) #1
Scott Hess - ex-Googler
LGTM.
9 years, 6 months ago (2011-06-08 20:09:03 UTC) #2
commit-bot: I haz the power
Try job failure for 7104062-1 on linux_clang for step "compile" (clobber build). It's a second ...
9 years, 6 months ago (2011-06-08 22:17:26 UTC) #3
Mark Mentovai
9 years, 6 months ago (2011-06-09 14:29:49 UTC) #4
LGTM-post-facto

Powered by Google App Engine
This is Rietveld 408576698