Issue 7104059: Revert 88111 - GTTF: Move --test-terminate-timeout logic to base/test/test_timeouts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104059: Revert 88111 - GTTF: Move --test-terminate-timeout logic to base/test/test_timeouts (Closed)

Created:
9 years, 6 months ago by Raghu Simha

Modified:
9 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 88111 - GTTF: Move --test-terminate-timeout logic to base/test/test_timeouts Reason for revert: This patch causes --test-terminate-timeout to be disregarded by out_of_proc_test_runner.cc, resulting in redness on the sync buildbots. This is the first step towards removing --test-terminate-timeout completely. In this CL --test-terminate-timeout becomes a synonym for --ui-test-action-max-timeout. This makes it possible to switch callers to --ui-test-action-max-timeout and remove --test-terminate-timeout. Removing number of different kinds of timeouts makes it easier to pick one. BUG=85287 Review URL: http://codereview.chromium.org/7111035 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88352

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5 lines)			Patch
M	base/test/test_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/test/test_switches.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/test/test_timeouts.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/test_launcher_utils.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK, thank you for keeping the tree green.

Expand Messages | Collapse Messages