Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 7104049: Re-enable the AutofillAfterReload test with some additional logging. (Closed)

Created:
9 years, 6 months ago by Ilya Sherman
Modified:
9 years, 6 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, GeorgeY, Ilya Sherman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable the AutofillAfterReload test with some additional logging. This logging is inspired by Xiyuan's change in http://codereview.chromium.org/7038026/ BUG=81451 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88405

Patch Set 1 #

Patch Set 2 : MSVC? #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
9 years, 6 months ago (2011-06-08 07:26:28 UTC) #1
dhollowa
http://codereview.chromium.org/7104049/diff/1002/chrome/browser/autofill/autofill_browsertest.cc File chrome/browser/autofill/autofill_browsertest.cc (right): http://codereview.chromium.org/7104049/diff/1002/chrome/browser/autofill/autofill_browsertest.cc#newcode391 chrome/browser/autofill/autofill_browsertest.cc:391: // Currently enabled for logging. Better to just delete ...
9 years, 6 months ago (2011-06-08 14:45:17 UTC) #2
dhollowa
9 years, 6 months ago (2011-06-08 14:45:55 UTC) #3
On 2011/06/08 14:45:17, dhollowa wrote:
>
http://codereview.chromium.org/7104049/diff/1002/chrome/browser/autofill/auto...
> File chrome/browser/autofill/autofill_browsertest.cc (right):
> 
>
http://codereview.chromium.org/7104049/diff/1002/chrome/browser/autofill/auto...
> chrome/browser/autofill/autofill_browsertest.cc:391: // Currently enabled for
> logging.
> Better to just delete these macros.  You can add them back the original if it
> fails.

Otherwise LGTM.

Powered by Google App Engine
This is Rietveld 408576698