First draft to enable turning off compositor for unit tests.

First draft to enable turning off compositor for unit tests.

Tests will be re-enabled when appropriate changes are made to support GL compositor testing.

BUG=unit tests not ready for GL compositor at this time.
TEST=unit tests run to completion.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88521

[wjmaclean, 2011-06-07 21:06:15]

This is running on the trybots now. Let me know if you think I've missed
anything.

[sky, 2011-06-07 23:21:20]

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
File chrome/test/unit/chrome_test_suite.cc (right):

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
chrome/test/unit/chrome_test_suite.cc:24: #include "views/view.h"
Only include this if TOOLKIT_VIEWS is set.

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
chrome/test/unit/chrome_test_suite.cc:147:
views::View::set_use_acceleration_when_possible(false);
Only do this if TOUCH_UI.

http://codereview.chromium.org/7104039/diff/1/views/run_all_unittests.cc
File views/run_all_unittests.cc (right):

http://codereview.chromium.org/7104039/diff/1/views/run_all_unittests.cc#newc...
views/run_all_unittests.cc:23:
views::View::set_use_acceleration_when_possible(false);
Only do this if TOUCH_UI.

[wjmaclean, 2011-06-08 13:24:03]

I figured out about the conditional compile stuff as soon as I saw the linux
trybot go red ... d'oh!

Let me know if this is good.

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
File chrome/test/unit/chrome_test_suite.cc (right):

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
chrome/test/unit/chrome_test_suite.cc:24: #include "views/view.h"
On 2011/06/07 23:21:20, sky wrote:
> Only include this if TOOLKIT_VIEWS is set.

Done.

http://codereview.chromium.org/7104039/diff/1/chrome/test/unit/chrome_test_su...
chrome/test/unit/chrome_test_suite.cc:147:
views::View::set_use_acceleration_when_possible(false);
On 2011/06/07 23:21:20, sky wrote:
> Only do this if TOUCH_UI.

Done.

Although, I'm not sure why it isn't TOOLKIT_VIEWS.

http://codereview.chromium.org/7104039/diff/1/views/run_all_unittests.cc
File views/run_all_unittests.cc (right):

http://codereview.chromium.org/7104039/diff/1/views/run_all_unittests.cc#newc...
views/run_all_unittests.cc:23:
views::View::set_use_acceleration_when_possible(false);
On 2011/06/07 23:21:20, sky wrote:
> Only do this if TOUCH_UI.

Done.

[sky, 2011-06-08 16:10:51]

LGTM

I'm not sure if we'll need to disable compositing for unit tests on windows.
That's why I said to make the conditional TOUCH_UI at this point. Although
perhaps it should be OS_LINUX.

[wjmaclean, 2011-06-09 13:25:34]

On 2011/06/08 16:10:51, sky wrote:
> LGTM
> 
> I'm not sure if we'll need to disable compositing for unit tests on windows.
> That's why I said to make the conditional TOUCH_UI at this point. Although
> perhaps it should be OS_LINUX.

I left it as TOUCHUI, as it seemed to me that OS_LINUX might be defined without
TOOLKIT_VIEWS, leading to compile errors.