Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8824)

Unified Diff: chrome/common/automation_messages_internal.h

Issue 7104029: Automation: fix chrome/browser dependency on chrome/test headers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/automation_constants.h ('k') | chrome/test/automation/autocomplete_edit_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/automation_messages_internal.h
===================================================================
--- chrome/common/automation_messages_internal.h (revision 87598)
+++ chrome/common/automation_messages_internal.h (working copy)
@@ -9,7 +9,6 @@
#include "base/string16.h"
#include "chrome/common/content_settings.h"
-#include "chrome/test/automation/autocomplete_edit_proxy.h"
#include "content/common/navigation_types.h"
#include "googleurl/src/gurl.h"
#include "ipc/ipc_message_macros.h"
@@ -17,7 +16,6 @@
#include "ui/gfx/rect.h"
#include "webkit/glue/window_open_disposition.h"
-
// NOTE: All IPC messages have either a routing_id of 0 (for asynchronous
// messages), or one that's been assigned by the proxy (for calls
// which expect a response). The routing_id shouldn't be used for
@@ -31,6 +29,8 @@
// of any of the messages below. This will be fixed once Xcode supports
// __COUNTER__, in which case we can get rid of the __LINE__.
+
+
#define IPC_MESSAGE_START AutomationMsgStart
// This message is fired when the AutomationProvider is up and running
@@ -341,10 +341,10 @@
bool /* success flag */,
int /* window handle */)
-// This message requests the AutocompleteEdit associated with the specified
-// browser handle.
-// The return value contains a success flag and the handle of the omnibox.
-IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_AutocompleteEditForBrowser,
+// TODO(phajdan.jr): Remove when the reference build is updated (this and
+// all others marked "DEPRECATED MESSAGE").
+// (intentionally blank line)
+IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_DEPRECATED_AutocompleteEditForBrowser,
int /* browser handle */,
bool /* success flag */,
int /* AutocompleteEdit handle */)
@@ -647,44 +647,44 @@
int,
bool)
-// This message requests the text currently being displayed in the
-// AutocompleteEdit. The parameter is the handle to the AutocompleteEdit.
-// The return value is a string indicating the text in the AutocompleteEdit.
-IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_AutocompleteEditGetText,
+// TODO(phajdan.jr): Remove when the reference build is updated (this and
+// all others marked "DEPRECATED MESSAGE").
+// (intentionally blank line)
+IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_DEPRECATED_AutocompleteEditGetText,
int /* autocomplete edit handle */,
bool /* the requested autocomplete edit exists */,
string16 /* omnibox text */)
-// This message sets the text being displayed in the AutocompleteEdit. The
-// first parameter is the handle to the omnibox and the second parameter is
-// the text to be displayed in the AutocompleteEdit.
-// The return value has no parameters and is returned when the operation has
-// completed.
-IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_AutocompleteEditSetText,
+// TODO(phajdan.jr): Remove when the reference build is updated (this and
+// all others marked "DEPRECATED MESSAGE").
+// (intentionally blank line)
+// (intentionally blank line)
+// (intentionally blank line)
+IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_DEPRECATED_AutocompleteEditSetText,
int /* autocomplete edit handle */,
string16 /* text to set */,
bool /* the requested autocomplete edit exists */)
-// This message requests if a query to a autocomplete provider is still in
-// progress. The first parameter in the request is the handle to the
-// autocomplete edit.
-// The first return value indicates if the request succeeded.
-// The second return value indicates if a query is still in progress.
+// TODO(phajdan.jr): Remove when the reference build is updated (this and
+// all others marked "DEPRECATED MESSAGE").
+// (intentionally blank line)
+// (intentionally blank line)
+// (intentionally blank line)
IPC_SYNC_MESSAGE_CONTROL1_2( \
- AutomationMsg_AutocompleteEditIsQueryInProgress,
+ AutomationMsg_DEPRECATED_AutocompleteEditIsQueryInProgress,
int /* autocomplete edit handle*/,
bool /* the requested autocomplete edit exists */,
bool /* indicates if a query is in progress */)
-// This message requests a list of the autocomplete messages currently being
-// displayed by the popup. The parameter in the request is a handle to the
-// autocomplete edit.
-// The first return value indicates if the request was successful, while
-// while the second is the actual list of matches.
-IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_AutocompleteEditGetMatches,
+// TODO(phajdan.jr): Remove when the reference build is updated (this and
+// all others marked "DEPRECATED MESSAGE").
+// (intentionally blank line)
+// (intentionally blank line)
+// (intentionally blank line)
+IPC_SYNC_MESSAGE_CONTROL1_2(AutomationMsg_DEPRECATED_AutocompleteEditGetMatches,
int /* autocomplete edit handle*/,
bool /* the requested autocomplete edit exists */,
- std::vector<AutocompleteMatchData> /* matches */)
+ std::vector<int> /* matches */)
// This message requests the execution of a browser command in the browser
// for which the handle is specified.
@@ -764,7 +764,7 @@
int /* tab_handle */,
size_t /* info bar index */,
bool /* wait for navigation */,
-// This line blank on purpose, see comment atop file about __LINE__.
+// (intentionally blank line), see comment atop file about __LINE__.
/* navigation result */
AutomationMsg_NavigationResponseValues)
@@ -779,7 +779,7 @@
IPC_SYNC_MESSAGE_CONTROL2_1(AutomationMsg_WaitForNavigation,
int /* tab_handle */,
int64 /* last navigation time */,
-// This line blank on purpose, see comment atop file about __LINE__.
+// (intentionally blank line), see comment atop file about __LINE__.
/* navigation result */
AutomationMsg_NavigationResponseValues)
@@ -1417,8 +1417,8 @@
size_t /* target count */,
bool /* success */)
-// Waits for the autocomplete edit to receive focus.
-IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_WaitForAutocompleteEditFocus,
+// TODO(phajdan.jr): Remove this message.
+IPC_SYNC_MESSAGE_CONTROL1_1(AutomationMsg_DEPRECATED_WaitForAutocompleteEditFocus,
int /* autocomplete edit handle */,
bool /* success */)
« no previous file with comments | « chrome/common/automation_constants.h ('k') | chrome/test/automation/autocomplete_edit_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698