Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 7104026: Stylistic fixes for BrowsingDataFileSystemHelper (Closed)

Created:
9 years, 6 months ago by Mike West
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Stylistic fixes for BrowsingDataFileSystemHelper. The only functional change is to drop the `profile_` property from the CannedBrowsingDataFileSystemHelper, which just stored it without ever touching it. I don't like keeping pointers around if I don't need them, so I'm dropping it here. BUG=None TEST=Read the code. Can you understand it? Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88647

Patch Set 1 #

Patch Set 2 : Dropping profile from CannedBrowsingDataThingie. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -79 lines) Patch
M chrome/browser/browsing_data_file_system_helper.h View 1 6 chunks +54 lines, -38 lines 0 comments Download
M chrome/browser/browsing_data_file_system_helper.cc View 1 9 chunks +51 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
This is incredibly low priority, so feel free to get back to me on it ...
9 years, 6 months ago (2011-06-01 15:33:53 UTC) #1
jochen (gone - plz use gerrit)
LGTM
9 years, 6 months ago (2011-06-01 19:55:41 UTC) #2
Mike West
I lied. There's a functional change: I can drop the `profile_` property from the CannedBrowsingDataFileSystemHelper, ...
9 years, 6 months ago (2011-06-09 17:06:00 UTC) #3
jochen (gone - plz use gerrit)
still LGTM
9 years, 6 months ago (2011-06-09 17:16:13 UTC) #4
commit-bot: I haz the power
9 years, 6 months ago (2011-06-10 07:55:58 UTC) #5
Change committed as 88647

Powered by Google App Engine
This is Rietveld 408576698