Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 7104019: ARM: Be consistent about the condition codes used with CompareObjectType (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2363 matching lines...) Expand 10 before | Expand all | Expand 10 after
2374 break; 2374 break;
2375 2375
2376 case STRING_CHECK: 2376 case STRING_CHECK:
2377 if (!function->IsBuiltin() && !function_info->strict_mode()) { 2377 if (!function->IsBuiltin() && !function_info->strict_mode()) {
2378 // Calling non-strict non-builtins with a value as the receiver 2378 // Calling non-strict non-builtins with a value as the receiver
2379 // requires boxing. 2379 // requires boxing.
2380 __ jmp(&miss); 2380 __ jmp(&miss);
2381 } else { 2381 } else {
2382 // Check that the object is a two-byte string or a symbol. 2382 // Check that the object is a two-byte string or a symbol.
2383 __ CompareObjectType(r1, r3, r3, FIRST_NONSTRING_TYPE); 2383 __ CompareObjectType(r1, r3, r3, FIRST_NONSTRING_TYPE);
2384 __ b(hs, &miss); 2384 __ b(ge, &miss);
2385 // Check that the maps starting from the prototype haven't changed. 2385 // Check that the maps starting from the prototype haven't changed.
2386 GenerateDirectLoadGlobalFunctionPrototype( 2386 GenerateDirectLoadGlobalFunctionPrototype(
2387 masm(), Context::STRING_FUNCTION_INDEX, r0, &miss); 2387 masm(), Context::STRING_FUNCTION_INDEX, r0, &miss);
2388 CheckPrototypes(JSObject::cast(object->GetPrototype()), r0, holder, r3, 2388 CheckPrototypes(JSObject::cast(object->GetPrototype()), r0, holder, r3,
2389 r1, r4, name, &miss); 2389 r1, r4, name, &miss);
2390 } 2390 }
2391 break; 2391 break;
2392 2392
2393 case NUMBER_CHECK: { 2393 case NUMBER_CHECK: {
2394 if (!function->IsBuiltin() && !function_info->strict_mode()) { 2394 if (!function->IsBuiltin() && !function_info->strict_mode()) {
(...skipping 1834 matching lines...) Expand 10 before | Expand all | Expand 10 after
4229 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric(); 4229 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric();
4230 __ Jump(ic, RelocInfo::CODE_TARGET); 4230 __ Jump(ic, RelocInfo::CODE_TARGET);
4231 } 4231 }
4232 4232
4233 4233
4234 #undef __ 4234 #undef __
4235 4235
4236 } } // namespace v8::internal 4236 } } // namespace v8::internal
4237 4237
4238 #endif // V8_TARGET_ARCH_ARM 4238 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698