Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: views/controls/textfield/native_textfield_views_unittest.cc

Issue 7104013: Convert NativeTextFieldViews context menu from Menu2 to MenuItemView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement reviewer recommendation. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/textfield/native_textfield_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/textfield/native_textfield_views_unittest.cc
diff --git a/views/controls/textfield/native_textfield_views_unittest.cc b/views/controls/textfield/native_textfield_views_unittest.cc
index 6307d6b1a58e32201b95d04d297e63e889ba86c6..30ff8e8bcc48b354f4147376840febd5d905251b 100644
--- a/views/controls/textfield/native_textfield_views_unittest.cc
+++ b/views/controls/textfield/native_textfield_views_unittest.cc
@@ -188,9 +188,9 @@ class NativeTextfieldViewsTest : public ViewsTestBase,
textfield_->RequestFocus();
}
- views::Menu2* GetContextMenu() {
- textfield_view_->InitContextMenuIfRequired();
- return textfield_view_->context_menu_menu_.get();
+ ui::MenuModel* GetContextMenuModel() {
+ textfield_view_->UpdateContextMenu();
+ return textfield_view_->context_menu_contents_.get();
}
protected:
@@ -537,11 +537,11 @@ void VerifyTextfieldContextMenuContents(bool textfield_has_selection,
TEST_F(NativeTextfieldViewsTest, ContextMenuDisplayTest) {
InitTextfield(Textfield::STYLE_DEFAULT);
textfield_->SetText(ASCIIToUTF16("hello world"));
- EXPECT_TRUE(GetContextMenu());
- VerifyTextfieldContextMenuContents(false, GetContextMenu()->model());
+ EXPECT_TRUE(GetContextMenuModel());
+ VerifyTextfieldContextMenuContents(false, GetContextMenuModel());
textfield_->SelectAll();
- VerifyTextfieldContextMenuContents(true, GetContextMenu()->model());
+ VerifyTextfieldContextMenuContents(true, GetContextMenuModel());
}
TEST_F(NativeTextfieldViewsTest, DoubleAndTripleClickTest) {
« no previous file with comments | « views/controls/textfield/native_textfield_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698