Disable the ACCELERATED_2D_CANVAS build flag on mac

Disable the ACCELERATED_2D_CANVAS build flag on mac

BUG=81678
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87482

[Justin Novosad, 2011-05-31 19:48:59]

PTAL

[M-A Ruel, 2011-05-31 19:53:08]

http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi
File build/features_override.gypi (right):

http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi#ne...
build/features_override.gypi:100: 'use_accelerated_compositing': 1,
That line is necessary?

[Justin Novosad, 2011-05-31 19:57:06]

I am not sure what it does, but it was already there (despite what the diff
looks like).  
On 2011/05/31 19:53:08, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi
> File build/features_override.gypi (right):
> 
>
http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi#ne...
> build/features_override.gypi:100: 'use_accelerated_compositing': 1,
> That line is necessary?

[M-A Ruel, 2011-05-31 19:58:44]

Mark, can you shed some light about why it is necessary?

[Mark Mentovai, 2011-05-31 20:01:21]

Did you try this without?

http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi
File build/features_override.gypi (right):

http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi#ne...
build/features_override.gypi:100: 'use_accelerated_compositing': 1,
Marc-Antoine Ruel wrote:
> That line is necessary?

I don’t think it is.

[Justin Novosad, 2011-05-31 20:08:03]

Good point, will try right now... this will take a while since I have to perform
a clean build.

On 2011/05/31 20:01:21, Mark Mentovai wrote:
> Did you try this without?
> 
> http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi
> File build/features_override.gypi (right):
> 
>
http://codereview.chromium.org/7102003/diff/1/build/features_override.gypi#ne...
> build/features_override.gypi:100: 'use_accelerated_compositing': 1,
> Marc-Antoine Ruel wrote:
> > That line is necessary?
> 
> I don’t think it is.

[Justin Novosad, 2011-05-31 20:49:37]

So it built fine with that line removed.  There is a similar tautology a few
lines later with use_threaded_compositing.  Shall I remove that line as well?

[Mark Mentovai, 2011-05-31 21:02:31]

http://codereview.chromium.org/7102003/diff/4003/build/features_override.gypi
File build/features_override.gypi (right):

http://codereview.chromium.org/7102003/diff/4003/build/features_override.gypi...
build/features_override.gypi:110: 'use_threaded_compositing': 1,
Yes, I think you can get rid of this too.

[Justin Novosad, 2011-05-31 22:07:21]

Required webkit change landed:
http://trac.webkit.org/changeset/87748
Plus a release build fix at 87750
This change can only go in once it is rolled-in

[commit-bot: I haz the power, 2011-06-01 14:33:20]

No LGTM from valid reviewers yet.

[M-A Ruel, 2011-06-01 14:34:18]

lgtm

[commit-bot: I haz the power, 2011-06-01 16:11:25]

Change committed as 87482