Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 7101012: Remove empty lines from the output while using --jobs. (Closed)

Created:
9 years, 6 months ago by Nicolas Sylvain
Modified:
9 years, 6 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Remove empty lines from the output while using --jobs. While using --jobs, empty lines are adding a lot of noise. An example output would look like: >gclient sync --jobs=10 1> 3> 4> 6> 5> 7> 5> 5>________ running 'git clone ...' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87542

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gclient_utils.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Sylvain
9 years, 6 months ago (2011-06-01 21:37:38 UTC) #1
M-A Ruel
lgtm with changes http://codereview.chromium.org/7101012/diff/1/gclient_utils.py File gclient_utils.py (right): http://codereview.chromium.org/7101012/diff/1/gclient_utils.py#newcode365 gclient_utils.py:365: if line != '': if line: ...
9 years, 6 months ago (2011-06-01 21:51:00 UTC) #2
Nicolas Sylvain
2011/6/1 <maruel@chromium.org> > lgtm with changes > > > http://codereview.chromium.org/7101012/diff/1/gclient_utils.py > File gclient_utils.py (right): > ...
9 years, 6 months ago (2011-06-01 21:54:38 UTC) #3
cmp
9 years, 6 months ago (2011-06-01 22:04:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698