src/liveedit.cc - Issue 7101011: Fix building with gdbjit=on (add missing isolate pointer parameter).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 7101011: Fix building with gdbjit=on (add missing isolate pointer parameter). (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Promote size_t to int64_t, not the other way around. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index def212f63767dd1b0d116d5cf7c351f6d0334c47..bc73445319faa614a4b233838b1c6ef4c531b090 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -93,8 +93,9 @@ class Differencer {

return;

}

multiply *= sizeof(int); // NOLINT

+ ASSERT(multiply >= 0);

Vyacheslav Egorov (Chromium) 2011/06/02 07:00:30 This compilation problem was reverted from svn.

size_t size = multiply;

- if (size != multiply) {

+ if (static_cast<int64_t>(size) != multiply) {

// Shouldn't be reachable.

ThrowStringException(

"Too many lines: "

« no previous file with comments | « src/gdb-jit.cc ('k') | no next file » | no next file with comments »