Issue 7101011: Fix building with gdbjit=on (add missing isolate pointer parameter).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7101011: Fix building with gdbjit=on (add missing isolate pointer parameter). (Closed)

Created:
9 years, 6 months ago by zarko

Modified:
9 years, 6 months ago

Reviewers:
Dmitry Lomov (no reviews), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Description

Fix building with gdbjit=on (add missing isolate pointer parameter). Fix a warning in liveedit.cc (signed/unsigned mismatch). Landed in 8161 BUG= TEST=

Patch Set 1 #

Patch Set 2 : Promote size_t to int64_t, not the other way around. #

Total comments: 1

Patch Set 3 : Rebase to master. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gdb-jit.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 6 months ago (2011-06-02 07:00:30 UTC) #3

LGTM

http://codereview.chromium.org/7101011/diff/1003/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/7101011/diff/1003/src/liveedit.cc#newcode96
src/liveedit.cc:96: ASSERT(multiply >= 0);
This compilation problem was reverted from svn.

Expand Messages | Collapse Messages