move EventHandler out of VideoCaptureController to make VS2005 happy

content/browser/renderer_host/video_capture_controller_event_handler.h

Index: content/browser/renderer_host/video_capture_controller_event_handler.h
===================================================================
--- content/browser/renderer_host/video_capture_controller_event_handler.h	(revision 0)
+++ content/browser/renderer_host/video_capture_controller_event_handler.h	(revision 0)
@@ -0,0 +1,41 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[jam, 2011/05/31 20:40:22]

you need to add this new file to content_browser.gypi.

[wjia(left Chromium), 2011/06/01 03:30:52]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_CONTROLLER_EVENT_HANDLER_H_
+#define CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_CONTROLLER_EVENT_HANDLER_H_
+
+#include <map>
+
+#include "base/time.h"
+#include "ui/gfx/surface/transport_dib.h"
+
+// Id used for identifying an object of VideoCaptureController.

[scherkus (not reviewing), 2011/05/31 20:42:00]

Id -> ID

[wjia(left Chromium), 2011/06/01 03:30:52]

Done.

+typedef std::pair<int32, int> VideoCaptureControllerID;

[scherkus (not reviewing), 2011/05/31 20:42:00]

did you see darin's comment about using a struct instead of std::pair?

[wjia(left Chromium), 2011/06/01 03:30:52]

Done.

+
+// VideoCaptureControllerEventHandler is the interface for
+// VideoCaptureController to use VideoCaptureHost services.

[scherkus (not reviewing), 2011/05/31 20:42:00]

pedantic nit: VideoCaptureController doesn't know that VideoCaptureHost exists
hence this interface

Otherwise you'd be passing in VideoCaptureHost pointer directly and do away w/
this class :)

[wjia(left Chromium), 2011/06/01 03:30:52]

Done.

+class VideoCaptureControllerEventHandler {
+ public:
+  // An Error have occurred in the VideoCaptureDevice.
+  virtual void OnError(VideoCaptureControllerID id) = 0;
+
+  // An TransportDIB have been filled with I420 video.
+  virtual void OnBufferReady(VideoCaptureControllerID id,
+                             TransportDIB::Handle handle,
+                             base::Time timestamp) = 0;
+
+  // The frame resolution the VideoCaptureDevice capture video in.
+  virtual void OnFrameInfo(VideoCaptureControllerID id,
+                           int width,
+                           int height,
+                           int frame_rate) = 0;
+
+  // Report that this object can be deleted.
+  virtual void OnReadyToDelete(VideoCaptureControllerID id) = 0;
+
+ protected:
+  virtual ~VideoCaptureControllerEventHandler() {}
+};
+
+#endif  // CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_CONTROLLER_EVENT_HANDLER_H_
Property changes on: content/browser/renderer_host/video_capture_controller_event_handler.h
___________________________________________________________________
Added: svn:eol-style
   + LF