Issue 7097015: Add missing branches in code generated for LModI with power-of-2 divisor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7097015: Add missing branches in code generated for LModI with power-of-2 divisor. (Closed)

Created:
9 years, 6 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 6 months ago

Reviewers:
fschneider, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add missing branches in code generated for LModI with power-of-2 divisor. BUG=v8:1476 TEST=test/mjsunit/regress/regress-1476.js Committed: http://code.google.com/p/v8/source/detail?r=8301

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -0 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-1476.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-06-15 19:53:30 UTC) #2

LGTM

http://codereview.chromium.org/7097015/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/7097015/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:892: __ b(al, &done);
Just use '__ b(&done);'?

Expand Messages | Collapse Messages