Improve CheckLongLines() to increase the hard limit at 50% when an exception is found.

tests/presubmit_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,R0201,W0212,W0403
 
@@ skipping 1409 matching lines @@
     """
     change1 = presubmit.Change(
         'foo1', 'foo1\n', self.fake_root_dir, None, 0, 0, None)
     input_api1 = self.MockInputApi(change1, False)
     affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
     input_api1.AffectedFiles(
         include_deletes=False,
         file_filter=mox.IgnoreArg()).AndReturn([affected_file])
     affected_file.NewContents().AndReturn([
         'ahoy',
-        'yo' + content1,
+        content1,
         'hay',
         'yer',
         'ya'])
 
     change2 = presubmit.Change(
         'foo2', 'foo2\n', self.fake_root_dir, None, 0, 0, None)
     input_api2 = self.MockInputApi(change2, False)
 
     input_api2.AffectedFiles(
         include_deletes=False,
         file_filter=mox.IgnoreArg()).AndReturn([affected_file])
     affected_file.NewContents().AndReturn([
         'ahoy',
-        'yo' + content2,
+        content2,
         'hay',
         'yer',
         'ya'])
+    # It falls back to ChangedContents when there is a failure. This is an
+    # optimization since NewContents() is much faster to execute than
+    # ChangedContents().
     affected_file.ChangedContents().AndReturn([
-        (42, 'yo, ' + content2),
+        (42, content2),
         (43, 'yer'),
         (23, 'ya')])
     affected_file.LocalPath().AndReturn('foo.cc')
 
     self.mox.ReplayAll()
 
     results1 = check(input_api1, presubmit.OutputApi, None)
     self.assertEquals(results1, [])
     results2 = check(input_api2, presubmit.OutputApi, None)
     self.assertEquals(len(results2), 1)
@@ skipping 179 matching lines @@
     self.mox.ReplayAll()
 
     results1 = presubmit_canned_checks.CheckChangeHasNoTabs(input_api1,
         presubmit.OutputApi, None)
     self.assertEquals(len(results1), 1)
     self.assertEquals(results1[0].__class__,
         presubmit.OutputApi.PresubmitPromptWarning)
     self.assertEquals(results1[0]._long_text,
         'makefile.foo, line 46')
 
-
   def testCannedCheckLongLines(self):
     check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
-    self.ContentTest(check, '', 'blah blah blah',
+    self.ContentTest(check, '0123456789', '01234567890',
                      presubmit.OutputApi.PresubmitPromptWarning)
 
+  def testCannedCheckLongLinesLF(self):
+    check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+    self.ContentTest(check, '012345678\n', '0123456789\n',
+                     presubmit.OutputApi.PresubmitPromptWarning)
+
+  def testCannedCheckLongLinesMacro(self):
+    check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+    self.ContentTest(
+        check,
+        # Put a space in so it doesn't trigger long symbols. Allow 1/3 more.
+        '#if 56 89 12 45',
+        '#if 56 89 12 456',
+        presubmit.OutputApi.PresubmitPromptWarning)
+
+  def testCannedCheckLongLinesHttp(self):
+    check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+    self.ContentTest(
+        check,
+        ' http:// 0 23 5',
+        ' http:// 0 23 56',
+        presubmit.OutputApi.PresubmitPromptWarning)
+
+  def testCannedCheckLongLinesLongSymbol(self):
+    check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+    self.ContentTest(
+        check,
+        ' TUP5D_LoNG_SY ',
+        ' TUP5D_LoNG_SY5 ',
+        presubmit.OutputApi.PresubmitPromptWarning)
+
   def testCheckChangeSvnEolStyleCommit(self):
     # Test CheckSvnProperty at the same time.
     self.SvnPropertyTest(presubmit_canned_checks.CheckChangeSvnEolStyle,
                          'svn:eol-style', 'LF', '', True,
                          presubmit.OutputApi.PresubmitError, True)
 
   def testCheckChangeSvnEolStyleUpload(self):
     self.SvnPropertyTest(presubmit_canned_checks.CheckChangeSvnEolStyle,
                          'svn:eol-style', 'LF', '', False,
                          presubmit.OutputApi.PresubmitNotifyResult, True)
@@ skipping 530 matching lines @@
         owners_check=True)
     self.assertEqual(1, len(results))
     self.assertEqual(
         'Found line ending with white spaces in:', results[0]._message)
     self.checkstdout('')
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()