Issue 7097012: Improve CheckLongLines() to increase the hard limit at 50% when an exception is found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7097012: Improve CheckLongLines() to increase the hard limit at 50% when an exception is found. (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Improve CheckLongLines() to increase the hard limit at 50% when an exception is found. Improve the list of exception to include very_long_symbol_names. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89696

Patch Set 1 #

Patch Set 2 : Fix regex to work properly, update unit test accordingly #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -11 lines)			Patch
	M	presubmit_canned_checks.py	View	1	1 chunk	+18 lines, -6 lines	1 comment	Download
	M	tests/presubmit_unittest.py	View	1	3 chunks	+37 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 6 months ago (2011-06-20 18:19:22 UTC) #3

LGTM.

http://codereview.chromium.org/7097012/diff/4/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/7097012/diff/4/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:320: line.startswith(MACROS) or
Hm. Didn't realize you can use tuples here. Cool.

Expand Messages | Collapse Messages