Issue 7097011: Add tracing of the stack height to full code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7097011: Add tracing of the stack height to full code generator. (Closed)

Created:
9 years, 6 months ago by William Hesse

Modified:
9 years, 4 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add tracing of the stack height to full code generator. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8755

Patch Set 3 : Fix all bugs except for for-in. #

Patch Set 4 : clean up change. #

Patch Set 5 : Remove more bugs. #

Patch Set 6 : fix flag-definitions.c #

Patch Set 7 : Remove effects of stack height tracing from other platforms. #

Patch Set 9 : Final version #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -11 lines)			Patch
M	src/flag-definitions.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/full-codegen.h	View	1 2 3 4 5 6 7	9 chunks	+49 lines, -4 lines	0 comments	Download
M	src/full-codegen.cc	View	1 2 3 4 5 6 7	11 chunks	+19 lines, -0 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3 4 5 6 7 8	80 chunks	+122 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

fschneider

http://codereview.chromium.org/7097011/diff/16001/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): http://codereview.chromium.org/7097011/diff/16001/src/mips/full-codegen-mips.cc#newcode374 src/mips/full-codegen-mips.cc:374: void FullCodeGenerator::verify_stack_height() {} Is this line necessary? You already ...

9 years, 5 months ago (2011-07-25 12:30:36 UTC) #4

LGTM.