Issue 7097002: Correctly locate the browser frame window to prevent a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7097002: Correctly locate the browser frame window to prevent a crash. (Closed)

Created:
9 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Correctly locate the browser frame window to prevent a crash. http://crbug.com/86072 TEST=chrome --first-run --user-data-dir=t ... wait 5 seconds, there should be no crash! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89056

Patch Set 1 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/first_run_bubble.cc	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Actually Miranda can look at this, since it's mostly a fix to FirstRunBubble code rather ...

9 years, 6 months ago (2011-06-14 19:33:38 UTC) #2

Miranda Callahan

9 years, 6 months ago (2011-06-14 20:02:24 UTC) #3

On 2011/06/14 19:33:38, Ben Goodger wrote:
> Actually Miranda can look at this, since it's mostly a fix to FirstRunBubble
> code rather than views.

LGTM, nice double-jump.

Expand Messages | Collapse Messages