Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4903)

Unified Diff: chrome/browser/ui/blocked_content/blocked_content_container.cc

Issue 7096016: Remove JS dialog dependency from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now a tc delegate Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/blocked_content_container.cc
diff --git a/chrome/browser/ui/blocked_content/blocked_content_container.cc b/chrome/browser/ui/blocked_content/blocked_content_container.cc
index 09defd8b93dac239cdf1bd97c0e78eceacd38959..11204ea6794228291373b76e89be08613cd7c58e 100644
--- a/chrome/browser/ui/blocked_content/blocked_content_container.cc
+++ b/chrome/browser/ui/blocked_content/blocked_content_container.cc
@@ -163,6 +163,12 @@ bool BlockedContentContainer::IsPopup(const TabContents* source) const {
return true;
}
+bool BlockedContentContainer::ShouldSuppressDialogs() {
+ // Suppress JavaScript dialogs when inside a constrained popup window (because
+ // that activates them and breaks them out of the constrained window jail).
+ return true;
+}
+
TabContents* BlockedContentContainer::GetConstrainingContents(
TabContents* source) {
return owner_->tab_contents();

Powered by Google App Engine
This is Rietveld 408576698