Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4967)

Unified Diff: chrome/browser/ui/app_modal_dialogs/message_box_handler.h

Issue 7096016: Remove JS dialog dependency from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more DEPS item removal Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_modal_dialogs/message_box_handler.h
diff --git a/chrome/browser/ui/app_modal_dialogs/message_box_handler.h b/chrome/browser/ui/app_modal_dialogs/message_box_handler.h
index 0acfb14c3006d640ee49b6443abc1e80d784e6fe..c92e382eb9af9ee9f37f7b6f2f0040f773fee719 100644
--- a/chrome/browser/ui/app_modal_dialogs/message_box_handler.h
+++ b/chrome/browser/ui/app_modal_dialogs/message_box_handler.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -8,10 +8,11 @@
#include <string>
+#include "base/string16.h"
#include "ipc/ipc_message.h"
class GURL;
-class JavaScriptAppModalDialogDelegate;
+class ChromeJavaScriptDialogDelegate;
class TabContents;
class Profile;
@@ -20,22 +21,22 @@ class Profile;
// default static display text is in |message_text| and if the dialog box is
// a user input prompt() box, the default text for the text field is in
// |default_prompt_text|. The result of the operation is returned using
-// |reply_msg|.
-void RunJavascriptMessageBox(Profile* profile,
- JavaScriptAppModalDialogDelegate* delegate,
+// |reply_msg|. TODO(avi): Remove Profile from this call; http://crbug.com/84601
+void RunJavascriptDialogImpl(Profile* profile,
+ ChromeJavaScriptDialogDelegate* delegate,
const GURL& frame_url,
int dialog_flags,
- const std::wstring& message_text,
- const std::wstring& default_prompt_text,
+ const string16& message_text,
+ const string16& default_prompt_text,
bool display_suppress_checkbox,
IPC::Message* reply_msg);
// This will display a modal dialog box with a header and footer asking the
// the user if they wish to navigate away from a page, with additional text
-// |message_text| between the header and footer. The users response is
+// |message_text| between the header and footer. The user's response is
// returned to the renderer using |reply_msg|.
-void RunBeforeUnloadDialog(TabContents* tab_contents,
- const std::wstring& message_text,
- IPC::Message* reply_msg);
+void RunBeforeUnloadDialogImpl(ChromeJavaScriptDialogDelegate* delegate,
+ const string16& message_text,
+ IPC::Message* reply_msg);
#endif // CHROME_BROWSER_UI_APP_MODAL_DIALOGS_MESSAGE_BOX_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698