Remove JS dialog dependency from content.

content/browser/content_browser_client.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #pragma once
 
 #include <string>
 
+#include "base/string16.h"
 #include "content/common/content_client.h"
 
 class BrowserRenderProcessHost;
 class CommandLine;
 class FilePath;
 class GURL;
 class PluginProcessHost;
 class Profile;
 class QuotaPermissionContext;
 class RenderViewHost;
 class TabContents;
 class WorkerProcessHost;
 
 namespace net {
 class CookieList;
 class CookieOptions;
 }
 
 namespace content {
 
+class JavaScriptDialogDelegate;
 class ResourceContext;
 class WebUIFactory;
 
 // Embedder API for participating in browser logic.
 class ContentBrowserClient {
  public:
   // Notifies that a new RenderHostView has been created.
   virtual void RenderViewHostCreated(RenderViewHost* render_view_host);
 
   // Notifies that a BrowserRenderProcessHost has been created. This is called
@@ skipping 61 matching lines @@
                               int render_process_id,
                               int render_view_id,
                               net::CookieOptions* options);
 
   // Create and return a new quota permission context.
   virtual QuotaPermissionContext* CreateQuotaPermissionContext();
 
   // Shows the given path using the OS file manager.
   virtual void RevealFolderInOS(const FilePath& path);
 
+  // Allow the embedder to display a JavaScript dialog. |did_suppress_message|
+  // will not be nil; if |true| is returned in it, the caller will handle faking
+  // the reply. TODO(avi): Remove Profile from this call; http://crbug.com/84601
+  virtual void RunJavaScriptDialog(JavaScriptDialogDelegate* delegate,

[jam, 2011/06/01 19:20:08]

i tend to think of ContentBrowserClient as a last-resort, where code that has no
context to reach into the embedder uses.  why not have TabContents call out to
TabContentsDelegate in this case?

[Avi (use Gerrit), 2011/06/01 19:40:34]

Lemme poke at that.

+                                   const GURL& frame_url,
+                                   int dialog_flags,
+                                   const string16& message_text,
+                                   const string16& default_prompt_text,
+                                   IPC::Message* reply_message,
+                                   bool* did_suppress_message,
+                                   Profile* profile);
+
+  // Allow the embedder to display a dialog asking the user if they want to
+  // leave a page. The users response is returned to the renderer using
+  // |reply_msg|.
+  virtual void RunBeforeUnloadDialog(JavaScriptDialogDelegate* delegate,
+                                     const string16& message_text,
+                                     IPC::Message* reply_msg);
+
+  // Resets any saved JavaScript dialog state for the delegate.
+  virtual void ResetJavaScriptState(JavaScriptDialogDelegate* delegate);
+
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
   // Can return an optional fd for crash handling, otherwise returns -1.
   virtual int GetCrashSignalFD(const std::string& process_type);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_CONTENT_BROWSER_CLIENT_H_