Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2541)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 7094006: Fix enabled state of an input field in the browser settings. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix spacing glitches Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options_startup_page_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 871e5206cf07576bd31e58d313a3a2c3169884f8..7001a9f2c80a83fac5ef89578337b512e0d8e362 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -402,7 +402,15 @@ cr.define('options', function() {
*/
updateCustomStartupPageControlStates_: function() {
var disable = !this.shouldEnableCustomStartupPageControls();
- $('startupPagesList').disabled = disable;
+ var startupPagesList = $('startupPagesList');
+ startupPagesList.disabled = disable;
+ // explicitly set disabled state for input text elements
James Hawkins 2011/06/08 17:38:31 s/explicitly/Explicitly/ Add period at end of sen
+ var inputs = startupPagesList.getElementsByTagName("input");
James Hawkins 2011/06/08 17:38:31 You can shorten this by searching on selector, "in
kevers 2011/06/08 20:08:35 Made the requested changes.
+ for (i = 0; i < inputs.length; i++) {
+ if (inputs[i].type == "text") {
+ inputs[i].disabled = disable;
+ }
+ }
$('startupUseCurrentButton').disabled = disable;
},
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options_startup_page_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698