Fix enabled state of an input field in the browser settings.

chrome/browser/resources/options/browser_options.js

Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 871e5206cf07576bd31e58d313a3a2c3169884f8..be6df4f3d37efaeb97f4657ad51e2beb3c6279bd 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -402,7 +402,15 @@ cr.define('options', function() {
      */
     updateCustomStartupPageControlStates_: function() {
       var disable = !this.shouldEnableCustomStartupPageControls();
-      $('startupPagesList').disabled = disable;
+      var startupPagesList = $('startupPagesList');
+      startupPagesList.disabled = disable;
+      // explicitly set disabled state for input text elements

[Rick Byers, 2011/05/31 17:35:25]

This approach seems OK.

I'm not sure if Chrome supports a way of disabling input fields from CSS (eg.
see Mozilla docs here: https://developer.mozilla.org/en/CSS/-moz-user-input). 
If it does, then it would be cleaner in my opinion to just toggle a 'disabled'
class on the top-level element, and have a CSS rule that disables the input
elements underneath it when applied.  Not a big deal, but worth a quick look to
see if this is possible/simpler.

[kevers1, 2011/05/31 20:19:01]

Looks like no such option exists for chrome.

+      var inputs = startupPagesList.getElementsByTagName("input");
+      for( i = 0; i < inputs.length; i++ ) {

[Rick Byers, 2011/05/31 17:35:25]

Style nit: space before the open paren, not after it (see below for other
examples)

[kevers1, 2011/05/31 20:19:01]

fixed

+        if( inputs[i].type == "text" ) {
+          inputs[i].disabled = disable;
+        }
+      }
       $('startupUseCurrentButton').disabled = disable;
     },