Fix enabled state of an input field in the browser settings.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
   const ArrayDataModel = cr.ui.ArrayDataModel;
 
   //
   // BrowserOptions class
@@ skipping 384 matching lines @@
                 !this.homepage_is_newtabpage_pref_.managed));
     },
 
     /**
      * Sets the enabled state of the custom startup page list controls
      * based on the current startup radio button selection.
      * @private
      */
     updateCustomStartupPageControlStates_: function() {
       var disable = !this.shouldEnableCustomStartupPageControls();
-      $('startupPagesList').disabled = disable;
+      var startupPagesList = $('startupPagesList');
+      startupPagesList.disabled = disable;
+      // explicitly set disabled state for input text elements

[Rick Byers, 2011/05/31 17:35:25]

This approach seems OK.

I'm not sure if Chrome supports a way of disabling input fields from CSS (eg.
see Mozilla docs here: https://developer.mozilla.org/en/CSS/-moz-user-input). 
If it does, then it would be cleaner in my opinion to just toggle a 'disabled'
class on the top-level element, and have a CSS rule that disables the input
elements underneath it when applied.  Not a big deal, but worth a quick look to
see if this is possible/simpler.

[kevers1, 2011/05/31 20:19:01]

Looks like no such option exists for chrome.

+      var inputs = startupPagesList.getElementsByTagName("input");
+      for( i = 0; i < inputs.length; i++ ) {

[Rick Byers, 2011/05/31 17:35:25]

Style nit: space before the open paren, not after it (see below for other
examples)

[kevers1, 2011/05/31 20:19:01]

fixed

+        if( inputs[i].type == "text" ) {
+          inputs[i].disabled = disable;
+        }
+      }
       $('startupUseCurrentButton').disabled = disable;
     },
 
     /**
      * Handle change events of the preference
      * 'session.urls_to_restore_on_startup'.
      * @param {event} preference changed event.
      * @private
      */
     handleStartupPageListChange_: function(event) {
@@ skipping 62 matching lines @@
   BrowserOptions.updateAutocompleteSuggestions = function(suggestions) {
     BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions);
   };
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 
 });