Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3761)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 7093004: Sync: Refactor the ProfileSyncService and sync setup flow to remove use of WebUI from PSS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes and cleanups. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/sync_setup_overlay.js ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index efbda27977605d41a5bb1f7b0a7f0c75f6cc7f8e..141aec0fd7bf055f5a35ff9d972cef084139c392 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -38,7 +38,6 @@ class NotificationSource;
class Profile;
class ProfileSyncFactory;
class SigninManager;
-class WebUI;
namespace browser_sync {
class BackendMigrator;
@@ -244,27 +243,22 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
SyncSetupWizard& get_wizard() { return wizard_; }
- // Shows the login screen of the Sync setup wizard. |web_ui| is the WebUI
- // object for a current settings tab, NULL if one doesn't exist or the calling
- // code doesn't know.
- virtual void ShowLoginDialog(WebUI* web_ui);
+ // Shows the login screen of the Sync setup wizard.
+ virtual void ShowLoginDialog();
// This method handles clicks on "sync error" UI, showing the appropriate
- // dialog for the error condition (relogin / enter passphrase). |web_ui| is
- // the WebUI object for a current settings tab, NULL if one doesn't exist or
- // the calling code doesn't know.
- virtual void ShowErrorUI(WebUI* web_ui);
+ // dialog for the error condition (relogin / enter passphrase).
+ virtual void ShowErrorUI();
// Shows the configure screen of the Sync setup wizard. If |sync_everything|
// is true, shows the corresponding page in the customize screen; otherwise,
// displays the page that gives the user the ability to select which data
- // types to sync. |web_ui| is the WebUI object for a current settings tab,
- // NULL if one doesn't exist or the calling code doesn't know.
- void ShowConfigure(WebUI* web_ui, bool sync_everything);
+ // types to sync.
+ void ShowConfigure(bool sync_everything);
- void PromptForExistingPassphrase(WebUI* web_ui);
+ void PromptForExistingPassphrase();
- void ShowSyncSetup(WebUI* web_ui, SyncSetupWizard::State state);
+ void ShowSyncSetup(SyncSetupWizard::State state);
// Pretty-printed strings for a given StatusSummary.
static std::string BuildSyncStatusSummaryText(
« no previous file with comments | « chrome/browser/resources/options/sync_setup_overlay.js ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698