Sync: Refactor the ProfileSyncService and sync setup flow to remove use of WebUI from PSS.

chrome/browser/ui/webui/options/sync_setup_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/sync_setup_handler.h"
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/google/google_util.h"
@@ skipping 257 matching lines @@
   web_ui_->RegisterMessageCallback("SyncSetupSubmitAuth",
       NewCallback(this, &SyncSetupHandler::HandleSubmitAuth));
   web_ui_->RegisterMessageCallback("SyncSetupConfigure",
       NewCallback(this, &SyncSetupHandler::HandleConfigure));
   web_ui_->RegisterMessageCallback("SyncSetupPassphrase",
       NewCallback(this, &SyncSetupHandler::HandlePassphraseEntry));
   web_ui_->RegisterMessageCallback("SyncSetupPassphraseCancel",
       NewCallback(this, &SyncSetupHandler::HandlePassphraseCancel));
   web_ui_->RegisterMessageCallback("SyncSetupAttachHandler",
       NewCallback(this, &SyncSetupHandler::HandleAttachHandler));
+  web_ui_->RegisterMessageCallback("SyncSetupShowErrorUI",
+      NewCallback(this, &SyncSetupHandler::HandleShowErrorUI));
 }
 
 void SyncSetupHandler::ShowGaiaLogin(const DictionaryValue& args) {
   StringValue page("login");
   web_ui_->CallJavascriptFunction(
       "SyncSetupOverlay.showSyncSetupPage", page, args);
 }
 
 void SyncSetupHandler::ShowGaiaSuccessAndClose() {
   web_ui_->CallJavascriptFunction("SyncSetupOverlay.showSuccessAndClose");
@@ skipping 102 matching lines @@
 
   DCHECK(flow_);
   flow_->OnPassphraseEntry(passphrase);
 }
 
 void SyncSetupHandler::HandlePassphraseCancel(const ListValue* args) {
   DCHECK(flow_);
   flow_->OnPassphraseCancel();
 }
 
+// TODO(jhawkins): Too much logic going on in this method: refactor.
 void SyncSetupHandler::HandleAttachHandler(const ListValue* args) {
   DCHECK(web_ui_);
 
   ProfileSyncService* sync_service =
       web_ui_->GetProfile()->GetProfileSyncService();
   if (!sync_service) {
     // If there's no sync service, the user tried to manually invoke a syncSetup
     // URL, but sync features are disabled.  We need to close the overlay for
     // this (rare) case.
     web_ui_->CallJavascriptFunction("OptionsPage.closeOverlay");
     return;
   }
 
-  if (sync_service->get_wizard().IsVisible()) {
-    // The wizard and setup flow have been configured, all we need to do is
-    // attach the handler if we haven't already done so.
-    if (!flow_)
-      flow_ = sync_service->get_wizard().AttachSyncSetupHandler(this);
-    return;
-  }
+  SyncSetupWizard::State state;
 
   // The user is trying to manually load a syncSetup URL.  We should bring up
   // either a login or a configure flow based on the state of sync.
-  if (sync_service->HasSyncSetupCompleted()) {
-    sync_service->ShowConfigure(web_ui_, false);
-  } else {
-    sync_service->ShowLoginDialog(web_ui_);
-    ProfileSyncService::SyncEvent(ProfileSyncService::START_FROM_URL);
+  if (sync_service->HasSyncSetupCompleted())
+    state = SyncSetupWizard::CONFIGURE;
+  else
+    state = SyncSetupWizard::GAIA_LOGIN;
+
+  if (!flow_) {
+    sync_service->get_wizard().Step(state);

[binji, 2011/06/08 20:19:56]

This logic seems strange to me. Why do you have to step the state and then
advance to the same state?

[James Hawkins, 2011/06/08 22:33:39]

Indeed, though I'd like to change that in a separate CL.

[tim (not reviewing), 2011/06/09 14:50:36]

But how is this not broken? Shouldn't we just yank the call to Advance
altogether?  The flow is a part of the wizard, not the other way around, pretty
sneaky / circuitous to get it via the service.

+    flow_ = sync_service->get_wizard().AttachSyncSetupHandler(this);
   }
+
+  flow_->Advance(state);
 }
 
+void SyncSetupHandler::HandleShowErrorUI(const ListValue* args) {
+  if (!flow_) {
+    ProfileSyncService* service =
+        web_ui_->GetProfile()->GetProfileSyncService();
+    service->get_wizard().Step(SyncSetupWizard::NONFATAL_ERROR);
+    flow_ = service->get_wizard().AttachSyncSetupHandler(this);
+  }
+
+  flow_->Advance(SyncSetupWizard::NONFATAL_ERROR);
+}