Issue 7089003: Fix JSON issue with arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7089003: Fix JSON issue with arrays. (Closed)

Created:
9 years, 6 months ago by sandholm

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/json.js	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
	M	test/mjsunit/json.js	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

You could consider adding a regression test http://codereview.chromium.org/7089003/diff/2001/src/json.js File src/json.js (right): http://codereview.chromium.org/7089003/diff/2001/src/json.js#newcode197 src/json.js:197: stack.pop(); Please ...

9 years, 6 months ago (2011-05-30 10:28:09 UTC) #2

sandholm

Added a regression test as well. Please have another look. http://codereview.chromium.org/7089003/diff/2001/src/json.js File src/json.js (right): http://codereview.chromium.org/7089003/diff/2001/src/json.js#newcode197 ...

9 years, 6 months ago (2011-05-30 10:43:42 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 7089003: Fix JSON issue with arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages