chrome/browser/content_settings/content_settings_extension_provider.cc - Issue 7088017: Split incognito extension content settings in session-only and persistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_extension_provider.cc

Issue 7088017: Split incognito extension content settings in session-only and persistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_extension_provider.h ('k') | chrome/browser/content_settings/content_settings_pattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_extension_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_extension_provider.cc b/chrome/browser/content_settings/content_settings_extension_provider.cc

index e8f8a4e61a459495138c2cfd4235ada361396135..f95823abfb33a71cc8a1cc360e2bf00d4e853f1d 100644

--- a/chrome/browser/content_settings/content_settings_extension_provider.cc

+++ b/chrome/browser/content_settings/content_settings_extension_provider.cc

@@ -7,6 +7,7 @@

#include "chrome/browser/content_settings/content_settings_details.h"

#include "chrome/browser/extensions/extension_content_settings_store.h"

#include "chrome/browser/profiles/profile.h"

+#include "content/common/notification_details.h"

#include "content/common/notification_service.h"

#include "content/common/notification_source.h"

@@ -69,8 +70,9 @@ void ExtensionProvider::OnContentSettingChanged(

if (incognito_ != incognito)

return;

// TODO(markusheintz): Be more concise.

- NotifyObservers(ContentSettingsDetails(

- ContentSettingsPattern(), CONTENT_SETTINGS_TYPE_DEFAULT, ""));

+ ContentSettingsDetails details(

+ ContentSettingsPattern(), CONTENT_SETTINGS_TYPE_DEFAULT, std::string());

+ NotifyObservers(details);

}

void ExtensionProvider::OnDestruction() {