Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/options/personal_options.html

Issue 7088010: Layout adjustment for i18n compatibility. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/options/personal_options.css ('K') | « chrome/browser/resources/options/personal_options.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/personal_options.html
diff --git a/chrome/browser/resources/options/personal_options.html b/chrome/browser/resources/options/personal_options.html
index 344c7f80921cb8f6427cdf462c3f9f087cfc731c..ebbbfad0e5914ec1385d03d19cedc297a2376ff5 100644
--- a/chrome/browser/resources/options/personal_options.html
+++ b/chrome/browser/resources/options/personal_options.html
@@ -1,153 +1,144 @@
<div id="personal-page" class="page" hidden>
<h1 i18n-content="personalPage"></h1>
+ <div class="displaytable">
kevers 2011/06/02 19:03:36 Added <div> to make use of 'display:table' for i18
<if expr="pp_ifdef('chromeos')">
- <section>
- <h3 i18n-content="account"></h3>
- <div>
- <table class="option-control-table">
- <tr>
- <td>
- <img id='account-picture'
- src='chrome://theme/IDR_LOGIN_DEFAULT_USER'>
- </td>
- <td>
- <label>
- <input id="enable-screen-lock" type="checkbox"
- pref="settings.enable_screen_lock">
- <span i18n-content="enableScreenlock"></span>
- </label>
- </td>
- </tr>
- <tr>
- <td>
- <button id="change-picture-button" i18n-content="changePicture">
- </button>
- </td>
- </tr>
- </table>
- </div>
- </section>
-</if>
- <section id="sync-section">
- <h3 i18n-content="syncSection"></h3>
- <div>
- <div id="sync-overview" hidden>
- <div i18n-content="syncOverview"></div>
- <div i18n-content="syncFurtherOverview"></div>
- </div>
- <div id="sync-status" hidden>
- <span id="sync-status-text"></span>
- <button id="sync-action-link" class="link-button"></button>
- </div>
- <div id="sync-buttons">
- <button id="start-stop-sync" hidden></button>
- <button id="customize-sync" i18n-content="customizeSync" hidden>
+ <section>
+ <h3 i18n-content="account"></h3>
+ <div>
kevers 2011/06/02 19:03:36 Changed from using a table to fix vertical alignme
+ <img id='account-picture'
+ src='chrome://theme/IDR_LOGIN_DEFAULT_USER'>
+ <label>
+ <input id="enable-screen-lock" type="checkbox"
+ pref="settings.enable_screen_lock">
+ <span i18n-content="enableScreenlock"></span>
+ </label>
+ <br>
+ <button id="change-picture-button" i18n-content="changePicture">
</button>
</div>
- <div id="profiles-create" hidden>
- <span i18n-content="createNewProfile"></span>
- <div id="profiles-create-button">
- <button id="new-profile" i18n-content="createProfileButton"></button>
+ </section>
+</if>
+ <section id="sync-section">
+ <h3 i18n-content="syncSection"></h3>
+ <div>
+ <div id="sync-overview" hidden>
+ <div i18n-content="syncOverview"></div>
+ <div i18n-content="syncFurtherOverview"></div>
</div>
+ <div id="sync-status" hidden>
+ <span id="sync-status-text"></span>
+ <button id="sync-action-link" class="link-button"></button>
+ </div>
+ <div id="sync-buttons">
+ <button id="start-stop-sync" hidden></button>
+ <button id="customize-sync" i18n-content="customizeSync" hidden>
+ </button>
+ </div>
+ <div id="profiles-create" hidden>
+ <span i18n-content="createNewProfile"></span>
+ <div id="profiles-create-button">
+ <button id="new-profile" i18n-content="createProfileButton"></button>
+ </div>
+ </div>
+ <a id="privacy-dashboard-link" href="https://www.google.com/dashboard"
+ i18n-content="privacyDashboardLink" target="_blank" hidden></a>
</div>
- <a id="privacy-dashboard-link" href="https://www.google.com/dashboard"
- i18n-content="privacyDashboardLink" target="_blank" hidden></a>
- </div>
- </section>
- <section>
- <h3 i18n-content="passwords"></h3>
- <div>
- <div class="radio">
- <label>
- <input id="passwords-offersave" type="radio" name="passwords_radio"
- value="true" pref="profile.password_manager_enabled"
- metric="Options_PasswordManager">
- <span i18n-content="passwordsAskToSave"></span>
- </label>
- </div>
- <div class="radio">
- <label>
- <input id="passwords-neversave" type="radio" name="passwords_radio"
- value="false" pref="profile.password_manager_enabled"
- metric="Options_PasswordManager">
- <span i18n-content="passwordsNeverSave"></span>
- </label>
+ </section>
+ <section>
+ <h3 i18n-content="passwords"></h3>
+ <div>
+ <div class="radio">
+ <label>
+ <input id="passwords-offersave" type="radio" name="passwords_radio"
+ value="true" pref="profile.password_manager_enabled"
+ metric="Options_PasswordManager">
+ <span i18n-content="passwordsAskToSave"></span>
+ </label>
+ </div>
+ <div class="radio">
+ <label>
+ <input id="passwords-neversave" type="radio" name="passwords_radio"
+ value="false" pref="profile.password_manager_enabled"
+ metric="Options_PasswordManager">
+ <span i18n-content="passwordsNeverSave"></span>
+ </label>
+ </div>
+ <div><button id="manage-passwords"
+ i18n-content="manage_passwords"></button></div>
+ <!-- This makes the managed-banner appear when the "pref" is
+ configured by the IT administrator. -->
+ <input name="password_allow_show_hidden" type="text"
+ pref="profile.password_manager_allow_show_passwords" hidden>
</div>
- <div><button id="manage-passwords"
- i18n-content="manage_passwords"></button></div>
- <!-- This makes the managed-banner appear when the "pref" is
- configured by the IT administrator. -->
- <input name="password_allow_show_hidden" type="text"
- pref="profile.password_manager_allow_show_passwords" hidden>
- </div>
- </section>
- <section>
- <h3 i18n-content="autofill"></h3>
- <div>
- <div class="checkbox">
- <label>
- <input id="autofill-enabled" pref="autofill.enabled"
- metric="Options_FormAutofill" type="checkbox">
- <span i18n-content="autofillEnabled"></span>
- </label>
+ </section>
+ <section>
+ <h3 i18n-content="autofill"></h3>
+ <div>
+ <div class="checkbox">
+ <label>
+ <input id="autofill-enabled" pref="autofill.enabled"
+ metric="Options_FormAutofill" type="checkbox">
+ <span i18n-content="autofillEnabled"></span>
+ </label>
+ </div>
+ <button id="autofill-settings"
+ i18n-content="manageAutofillSettings"></button>
</div>
- <button id="autofill-settings"
- i18n-content="manageAutofillSettings"></button>
- </div>
- </section>
+ </section>
<if expr="not pp_ifdef('chromeos')">
- <section>
- <h3 i18n-content="browsingData"></h3>
- <div>
- <button id="import-data" i18n-content="importData"></button>
- </div>
- </section>
+ <section>
+ <h3 i18n-content="browsingData"></h3>
+ <div>
+ <button id="import-data" i18n-content="importData"></button>
+ </div>
+ </section>
</if>
<if expr="not pp_ifdef('toolkit_views') and (os == 'linux2' or os.find('bsd') != -1 or os == 'sunos5')">
- <section>
- <h3 i18n-content="appearance"></h3>
- <div>
+ <section>
+ <h3 i18n-content="appearance"></h3>
<div>
- <button id="themes-GTK-button"
- i18n-content="themesGTKButton"></button>
- <button id="themes-reset"
- i18n-content="themesSetClassic"></button>
- </div>
- <div id="themes-gallery-div">
- <a id="themes-gallery" i18n-content="themesGallery"
- i18n-values="href:themesGalleryURL" target="_blank"></a>
- </div>
- <div class="radio">
- <label>
- <input name="decorations_radio"
- pref="browser.custom_chrome_frame"
- type="radio" value="false" metric="Options_CustomFrame">
- <span i18n-content="showWindowDecorations"></span>
- </label>
- </div>
- <div class="radio">
- <label>
- <input name="decorations_radio"
- pref="browser.custom_chrome_frame"
- type="radio" value="true" metric="Options_CustomFrame">
- <span i18n-content="hideWindowDecorations"></span>
- </label>
+ <div>
+ <button id="themes-GTK-button"
+ i18n-content="themesGTKButton"></button>
+ <button id="themes-reset"
+ i18n-content="themesSetClassic"></button>
+ </div>
+ <div id="themes-gallery-div">
+ <a id="themes-gallery" i18n-content="themesGallery"
+ i18n-values="href:themesGalleryURL" target="_blank"></a>
+ </div>
+ <div class="radio">
+ <label>
+ <input name="decorations_radio"
+ pref="browser.custom_chrome_frame"
+ type="radio" value="false" metric="Options_CustomFrame">
+ <span i18n-content="showWindowDecorations"></span>
+ </label>
+ </div>
+ <div class="radio">
+ <label>
+ <input name="decorations_radio"
+ pref="browser.custom_chrome_frame"
+ type="radio" value="true" metric="Options_CustomFrame">
+ <span i18n-content="hideWindowDecorations"></span>
+ </label>
+ </div>
</div>
- </div>
- </section>
+ </section>
</if>
<if expr="pp_ifdef('toolkit_views') or os == 'win32' or os == 'darwin'">
- <section>
- <h3 i18n-content="themes"></h3>
- <div>
+ <section>
+ <h3 i18n-content="themes"></h3>
<div>
- <button id="themes-reset" i18n-content="themesReset"></button>
- </div>
- <div id="themes-gallery-div">
- <a id="themes-gallery" i18n-content="themesGallery"
- i18n-values="href:themesGalleryURL" target="_blank"></a>
+ <div>
+ <button id="themes-reset" i18n-content="themesReset"></button>
+ </div>
+ <div id="themes-gallery-div">
+ <a id="themes-gallery" i18n-content="themesGallery"
+ i18n-values="href:themesGalleryURL" target="_blank"></a>
+ </div>
</div>
- </div>
- </section>
+ </section>
</if>
+ </div>
</div>
« chrome/browser/resources/options/personal_options.css ('K') | « chrome/browser/resources/options/personal_options.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698