Issue 7087031: LiveEdit: Optimize compare by stripping common suffix and prefix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7087031: LiveEdit: Optimize compare by stripping common suffix and prefix. (Closed)

Created:
9 years, 6 months ago by Peter Rybin

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

LiveEdit: Optimize compare by stripping common suffix and prefix.

Patch Set 3 : merge #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -17 lines)			Patch
	M	src/liveedit.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/liveedit.cc	View	1 2	9 chunks	+110 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc#newcode288 src/liveedit.cc:288: virtual void setSubrange1(int offset, int len) = 0; ...

9 years, 6 months ago (2011-05-31 08:09:19 UTC) #2

Peter Rybin

9 years, 6 months ago (2011-05-31 15:02:22 UTC) #3

http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc#newcode288
src/liveedit.cc:288: virtual void setSubrange1(int offset, int len) = 0;
On 2011/05/31 08:09:19, Søren Gjesse wrote:
> set -> Set (times 4)

Oh sorry, cannot properly switch to C++ again. :(
Done

http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc#newcode333
src/liveedit.cc:333: if (common_prefix_len > 0 || common_suffix_len) {
On 2011/05/31 08:09:19, Søren Gjesse wrote:
> common_suffix_len -> common_suffix_len > 0

Thanks, missed this!
Done

http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc#newcode478
src/liveedit.cc:478: int getLength1() {
On 2011/05/31 08:09:19, Søren Gjesse wrote:
> get -> Get

Done.

http://codereview.chromium.org/7087031/diff/2001/src/liveedit.cc#newcode484
src/liveedit.cc:484: bool equals(int index1, int index2) {
On 2011/05/31 08:09:19, Søren Gjesse wrote:
> equals -> Equals

Done.

Expand Messages | Collapse Messages

Issue 7087031: LiveEdit: Optimize compare by stripping common suffix and prefix. (Closed)

Description

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : merge #

Messages