Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: webkit/glue/resource_fetcher_unittest.cc

Issue 7087028: roll clang 131935:132017 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/resource_fetcher_unittest.cc
diff --git a/webkit/glue/resource_fetcher_unittest.cc b/webkit/glue/resource_fetcher_unittest.cc
index 2888a94817ddb71513edaf764bd697ee3a065732..9ef0fc61df6da0173c0f174bce5ad68349348fc9 100644
--- a/webkit/glue/resource_fetcher_unittest.cc
+++ b/webkit/glue/resource_fetcher_unittest.cc
@@ -40,6 +40,8 @@ class FetcherDelegate {
StartTimer();
}
+ virtual ~FetcherDelegate() {}
+
ResourceFetcher::Callback* NewCallback() {
return ::NewCallback(this, &FetcherDelegate::OnURLFetchComplete);
}
@@ -173,12 +175,14 @@ TEST_F(ResourceFetcherTests, ResourceFetcherTimeout) {
class EvilFetcherDelegate : public FetcherDelegate {
public:
+ virtual ~EvilFetcherDelegate() {}
+
void SetFetcher(ResourceFetcher* fetcher) {
fetcher_.reset(fetcher);
}
- void OnURLFetchComplete(const WebURLResponse& response,
- const std::string& data) {
+ virtual void OnURLFetchComplete(const WebURLResponse& response,
+ const std::string& data) {
// Destroy the ResourceFetcher here. We are testing that upon returning
// to the ResourceFetcher that it does not crash.
fetcher_.reset();

Powered by Google App Engine
This is Rietveld 408576698