Support automatic javascript test registry in gtest when creating WebUI tests.

tools/gypv8sh.py

Index: tools/gypv8sh.py
diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py
new file mode 100755
index 0000000000000000000000000000000000000000..7a8a09b5d987b6975c563edbaad374c2ee53e3f5
--- /dev/null
+++ b/tools/gypv8sh.py
@@ -0,0 +1,73 @@
+#!/usr/bin/python
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+#
+# This script is used by chrome_tests.gypi's js2webui action to maintain the
+# argument lists and to generate inlinable tests.
+#
+# Usage:
+#   python tools/gypv8sh.py -p product_dir path/to/javascript2webui.js
+#   python tools/gypv8sh.py -t # print test_harnesses
+#   python tools/gypv8sh.py -i # print inputs
+#   python tools/gypv8sh.py -o # print outputs
+import json
+import optparse
+import os
+import subprocess
+import sys
+
+# Please adjust the following to edit or add new javascript webui tests.
+rules = [
+    [
+        'WebUIBrowserTestPass',
+        'test/data/webui/sample_pass.js',
+        'browser/ui/webui/web_ui_browsertest-inl.h',
+        ],
+    ]
+
+def set_add(option, opt_str, value, parser, the_set, the_value):
+  the_set.add(the_value)
+
+# For options -t, -i, & -o, we print the "column" of the |rules|.  We keep a set
+# of indices to print in |print_rule_indices| and print them in sorted order if
+# non-empty.
+print_rule_indices = set()
+parser = optparse.OptionParser();
+parser.add_option('-v', '--verbose', action='store_true', dest='verbose')
+parser.add_option('-n', '--impotent', action='store_true', dest='impotent',
+                  help="don't execute; just print (as if verbose)")
+parser.add_option('-p', '--product_dir', action='store', type='string',
+                  dest='product_dir',
+                  help='for gyp to set the <(PRODUCT_DIR) for running v8_shell')
+parser.add_option('-t', '--test_fixture', action='callback', callback=set_add,
+                  callback_args=tuple([print_rule_indices, 0]),
+                  help='print test_fixtures')
+parser.add_option('-i', '--in', action='callback', callback=set_add,
+                  callback_args=tuple([print_rule_indices, 1]),
+                  help='print inputs')
+parser.add_option('-o', '--out', action='callback', callback=set_add,
+                  callback_args=tuple([print_rule_indices, 2]),
+                  help='print outputs')
+(opts, args) = parser.parse_args();
+
+if len(print_rule_indices):
+  for rule in rules:
+    for index in sorted(print_rule_indices):
+      print rule[index],
+    print
+else:
+  if not opts.product_dir:
+    print "Need to supply the -p PRODUCT_DIR."
+    parser.print_help();
+    parser.exit(status=-1);

[Paweł Hajdan Jr., 2011/06/15 08:12:31]

Sorry, I was thinking about parser.error (just replace entire body of this "if"
with parser.error("--product_dir option is required")).

[Sheridan Rawlins, 2011/06/15 23:54:32]

I really don't like the result as much.  With the current code, you get:

Need to supply the -p PRODUCT_DIR.
Usage: gypv8sh.py [options]

Options:
  -h, --help            show this help message and exit
  -v, --verbose         
  -n, --impotent        don't execute; just print (as if verbose)
  -p PRODUCT_DIR, --product_dir=PRODUCT_DIR
                        for gyp to set the <(PRODUCT_DIR) for running v8_shell
  -t, --test_fixture    print test_fixtures
  -i, --in              print inputs
  -o, --out             print outputs

With your recommendation, you get

Usage: gypv8sh.py [options]

gypv8sh.py: error: --product_dir option is required.

The help is much more useful than the usage as it actually describes the
--product_dir option.

On 2011/06/15 08:12:31, Paweł Hajdan Jr. wrote:

[Paweł Hajdan Jr., 2011/06/16 17:50:10]

This is a good point, but I think consistency is better.

However, you'll be working much more frequently with this tool than I'll be, so
if it's important for you, feel free to leave the current version as is. In that
case, I'd have a small nit (also up to you): change "status=-1" to just "-1".

[Sheridan Rawlins, 2011/06/17 00:44:55]

As it turns out you can adjust the usage with parser.set_usage().  It's a little
redundant for the programmer to maintain (I wish optparse would do it for me),
but I did that and changed to the error() call.

On 2011/06/16 17:50:10, Paweł Hajdan Jr. wrote:

+  v8_shell = os.path.join(opts.product_dir, 'v8_shell')
+  jsfilename = args[0]
+  for rule in rules:
+    arguments = [jsfilename, rule[0], rule[1], os.path.basename(rule[1])]
+    arguments = "arguments=" + json.dumps(arguments)
+    cmd = [v8_shell, '-e', arguments, jsfilename]
+    if opts.verbose or opts.impotent:
+      print cmd
+    if not opts.impotent:
+      sys.exit(subprocess.call(cmd, stdout=open(rule[2],'w+')))