Support automatic javascript test registry in gtest when creating WebUI tests.

chrome/browser/ui/webui/web_ui_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
 
 #include <string>
 #include <vector>
 
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 186 matching lines @@
   AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
 
   // Navigate to UI.
   // TODO(dtseng): make accessor for subclasses to return?
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
 
   ASSERT_TRUE(RunJavascriptTest("testAssertFalse"));
   ASSERT_TRUE(RunJavascriptTest("testInitialFocus"));
   ASSERT_FALSE(RunJavascriptTest("testConsoleError"));
 }
+
+class WebUIBrowserTestPass : public WebUIBrowserTest {
+  virtual void SetUpOnMainThread() {

[Paweł Hajdan Jr., 2011/06/13 19:38:40]

Shouldn't you call parent's SetUpOnMainThread or rather use TEST_F? What is this
test testing?

[Sheridan Rawlins, 2011/06/13 22:18:54]

This is not a test.  It is the "framework" class for the tests created in the
inlined file below.  Because the web test framework written by David needs a
domui page, navigating to that page must be done by the C++.  For Print Preview,
there is far more setup to register mock objects, navigate to a test page, cause
it to print, and wait for the newly created print tab to open.

FWIW, the generated content at the time of writing is:
// GENERATED FILE
// browser/ui/webui/javascript2webui.js WebUIBrowserTestPass
test/data/webui/sample_pass.js sample_pass.js
// PLEASE DO NOT HAND EDIT!

IN_PROC_BROWSER_TEST_F(WebUIBrowserTestPass, testAssertFalse) {
  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_pass.js")));
  ASSERT_TRUE(RunJavascriptTest("testAssertFalse"));
}

IN_PROC_BROWSER_TEST_F(WebUIBrowserTestPass, testAssertTrue) {
  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_pass.js")));
  ASSERT_TRUE(RunJavascriptTest("testAssertTrue"));
}

IN_PROC_BROWSER_TEST_F(WebUIBrowserTestPass, testAssertEquals) {
  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_pass.js")));
  ASSERT_TRUE(RunJavascriptTest("testAssertEquals"));
}

On 2011/06/13 19:38:40, Paweł Hajdan Jr. wrote:

[Paweł Hajdan Jr., 2011/06/14 20:23:17]

I see. That still doesn't explain not calling parent's virtual method, and also
please just put in comment (a bit shorter) the above explanation.

[Sheridan Rawlins, 2011/06/14 22:39:26]

  // Override this to add any custom setup code that needs to be done on the
  // main thread after the browser is created and just before calling
  // RunTestOnMainThread().
  virtual void SetUpOnMainThread() {}

WebUIBrowserTest does not override this.  Sometimes virtual methods need to call
the parent's method, sometimes they don't and you must rely on comments & code
to guide you. This particular function doesn't appear to need to call the
parent's impl.

On 2011/06/14 20:23:17, Paweł Hajdan Jr. wrote:

[Paweł Hajdan Jr., 2011/06/15 08:12:31]

... and when WebUIBrowserTest _does_ override SetUpOnMainThread good luck
maintaining the mess and comments lying to you.

Please just call the parent's method; not doing so and relying on comments that
can get out of sync with reality is asking for trouble (and yes, I remember
things like that happening in the past and it was bad).

[Sheridan Rawlins, 2011/06/15 23:54:32]

Done.

+    ui_test_utils::NavigateToURL(browser(),
+                                 GURL(chrome::kChromeUIDownloadsURL));
+  }
+};
+
+#include "chrome/browser/ui/webui/web_ui_browsertest-inl.h"