Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 7087011: Printing: Add ability to get the default printer from the print backend. (Closed)

Created:
9 years, 6 months ago by Lei Zhang
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Printing: Add ability to get the default printer from the print backend. BUG=84126 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87187

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M printing/backend/print_backend.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 2 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
9 years, 6 months ago (2011-05-28 00:55:55 UTC) #1
Lei Zhang
It turns out in many cases, enumerating the printers takes longer than the time it ...
9 years, 6 months ago (2011-05-28 00:57:37 UTC) #2
vandebo (ex-Chrome)
LGTM
9 years, 6 months ago (2011-05-28 18:21:39 UTC) #3
vandebo (ex-Chrome)
Oops, here are my nits. LGTM http://codereview.chromium.org/7087011/diff/5/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): http://codereview.chromium.org/7087011/diff/5/printing/backend/print_backend_win.cc#newcode91 printing/backend/print_backend_win.cc:91: // Getting the ...
9 years, 6 months ago (2011-05-28 18:22:01 UTC) #4
Lei Zhang
http://codereview.chromium.org/7087011/diff/5/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): http://codereview.chromium.org/7087011/diff/5/printing/backend/print_backend_win.cc#newcode91 printing/backend/print_backend_win.cc:91: // Getting the name of the default printer. On ...
9 years, 6 months ago (2011-05-28 20:50:18 UTC) #5
vandebo (ex-Chrome)
LG
9 years, 6 months ago (2011-05-28 21:19:52 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-05-28 21:50:30 UTC) #7
Change committed as 87187

Powered by Google App Engine
This is Rietveld 408576698