Issue 7087009: FilePath: remove some functions that aren't really used.

Issue 7087009: FilePath: remove some functions that aren't really used. (Closed)

Created:
9 years, 7 months ago by Evan Martin

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, tony, willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

FilePath: remove some functions that aren't really used. And fix the one caller. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87327

Patch Set 4 : simpler #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -43 lines)			Patch
M	base/file_path.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/file_path.cc	View	1 2 3	1 chunk	+9 lines, -26 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.cc	View	1	4 chunks	+14 lines, -10 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Not sure how these snuck in, but they're getting the boot now.

9 years, 7 months ago (2011-05-27 22:52:10 UTC) #1

Evan Martin

It's Friday evening, the east-coasters have probably gone home.

9 years, 7 months ago (2011-05-27 23:04:25 UTC) #2

tony

http://codereview.chromium.org/7087009/diff/4002/chrome/browser/bookmarks/bookmark_node_data.cc File chrome/browser/bookmarks/bookmark_node_data.cc (right): http://codereview.chromium.org/7087009/diff/4002/chrome/browser/bookmarks/bookmark_node_data.cc#newcode207 chrome/browser/bookmarks/bookmark_node_data.cc:207: elements, &profile_path_.value()); This looks like a compile error.

9 years, 7 months ago (2011-05-27 23:30:20 UTC) #4

Mark Mentovai

9 years, 7 months ago (2011-05-27 23:39:56 UTC) #5

LGTM with this fixed.

I wasn’t aware of these functions being added either. Apparently they’ve been in
here for over a year.

The east coast should have gone home. In fact, I took the whole day off. I still
managed to sneak in a ton of code reviews.

http://codereview.chromium.org/7087009/diff/4002/chrome/browser/bookmarks/boo...
File chrome/browser/bookmarks/bookmark_node_data.cc (right):

http://codereview.chromium.org/7087009/diff/4002/chrome/browser/bookmarks/boo...
chrome/browser/bookmarks/bookmark_node_data.cc:207: elements,
&profile_path_.value());
tony wrote:
> This looks like a compile error.

Yup.

Expand Messages | Collapse Messages