Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/stub-cache.cc

Issue 7086029: Fix a number of IC stubs to correctly set the call kind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Load global object from rsi on x64. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.h ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 Object* code = map_holder->map()->FindInCodeCache(name, flags); 922 Object* code = map_holder->map()->FindInCodeCache(name, flags);
923 if (code->IsUndefined()) { 923 if (code->IsUndefined()) {
924 // If the function hasn't been compiled yet, we cannot do it now 924 // If the function hasn't been compiled yet, we cannot do it now
925 // because it may cause GC. To avoid this issue, we return an 925 // because it may cause GC. To avoid this issue, we return an
926 // internal error which will make sure we do not update any 926 // internal error which will make sure we do not update any
927 // caches. 927 // caches.
928 if (!function->is_compiled()) return Failure::InternalError(); 928 if (!function->is_compiled()) return Failure::InternalError();
929 CallStubCompiler compiler( 929 CallStubCompiler compiler(
930 argc, in_loop, kind, extra_ic_state, cache_holder); 930 argc, in_loop, kind, extra_ic_state, cache_holder);
931 { MaybeObject* maybe_code = 931 { MaybeObject* maybe_code =
932 compiler.CompileCallGlobal(receiver, 932 compiler.CompileCallGlobal(receiver, holder, cell, function, name);
933 holder,
934 cell,
935 function,
936 name,
937 extra_ic_state);
938 if (!maybe_code->ToObject(&code)) return maybe_code; 933 if (!maybe_code->ToObject(&code)) return maybe_code;
939 } 934 }
940 ASSERT_EQ(flags, Code::cast(code)->flags()); 935 ASSERT_EQ(flags, Code::cast(code)->flags());
941 PROFILE(isolate(), 936 PROFILE(isolate(),
942 CodeCreateEvent(CALL_LOGGER_TAG(kind, CALL_IC_TAG), 937 CodeCreateEvent(CALL_LOGGER_TAG(kind, CALL_IC_TAG),
943 Code::cast(code), name)); 938 Code::cast(code), name));
944 GDBJIT(AddCode(GDBJITInterface::CALL_IC, name, Code::cast(code))); 939 GDBJIT(AddCode(GDBJITInterface::CALL_IC, name, Code::cast(code)));
945 Object* result; 940 Object* result;
946 { MaybeObject* maybe_result = 941 { MaybeObject* maybe_result =
947 map_holder->UpdateMapCodeCache(name, Code::cast(code)); 942 map_holder->UpdateMapCodeCache(name, Code::cast(code));
(...skipping 1008 matching lines...) Expand 10 before | Expand all | Expand 10 after
1956 } 1951 }
1957 Code* code = Code::cast(result); 1952 Code* code = Code::cast(result);
1958 USE(code); 1953 USE(code);
1959 PROFILE(isolate(), 1954 PROFILE(isolate(),
1960 CodeCreateEvent(Logger::STUB_TAG, code, "ExternalArrayStoreStub")); 1955 CodeCreateEvent(Logger::STUB_TAG, code, "ExternalArrayStoreStub"));
1961 return result; 1956 return result;
1962 } 1957 }
1963 1958
1964 1959
1965 } } // namespace v8::internal 1960 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/stub-cache.h ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698