Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 7085034: Reapply change to Pass undefined to JS builtins when called with (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 6 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Reapply change to Pass undefined to JS builtins when called with implicit receiver. A couple of corner cases have to be treated specially to not break everything: eval and getter/setter definitions. R=fschneider@chromium.org BUG=v8:1365 TEST=mjsunit/regress/regress-1365.js Committed: http://code.google.com/p/v8/source/detail?r=8110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -134 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler.h View 3 chunks +13 lines, -2 lines 0 comments Download
M src/compiler.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.h View 3 chunks +11 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/v8natives.js View 6 chunks +28 lines, -15 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1170.js View 2 chunks +5 lines, -6 lines 0 comments Download
M test/mjsunit/regress/regress-124.js View 2 chunks +4 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-1365.js View 1 chunk +31 lines, -32 lines 0 comments Download
M test/mjsunit/regress/regress-485.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 6 months ago (2011-05-30 13:35:15 UTC) #1
fschneider
9 years, 6 months ago (2011-05-30 13:44:06 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698