Issue 7085022: Add support for auto-props in the form: "*.sh = svn:eol-style=LF;svn:executable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7085022: Add support for auto-props in the form: "*.sh = svn:eol-style=LF;svn:executable" (Closed)

Created:
9 years, 7 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add support for auto-props in the form: "*.sh = svn:eol-style=LF;svn:executable" It needs to be parsed manually and assumes '=*' for property that do not specify a value. Add clearer message on failure like that by specifiying the command line. R=dpranke@chromium.org BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment to be clearer #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -17 lines)			Patch
	M	checkout.py	View	1	5 chunks	+29 lines, -15 lines	0 comments	Download
	M	tests/checkout_test.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 6 months ago (2011-05-30 20:10:59 UTC) #2

LGTM.

http://codereview.chromium.org/7085022/diff/1/checkout.py
File checkout.py (right):

http://codereview.chromium.org/7085022/diff/1/checkout.py#newcode254
checkout.py:254: # the error message. It is not necessary here anyway.
change "it" to "they" in "it could leak" and "it is not necessary"?

Expand Messages | Collapse Messages