Issue 7085012: Revert r928 and r918.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7085012: Revert r928 and r918. (Closed)

Created:
9 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

Description

make: Revert r928 and r918. These changes are correct, but we have many incorrect build files in the Chrome tree. We can't implement these changes until the build files are fixed. Committed: http://code.google.com/p/gyp/source/detail?r=930

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -29 lines)			Patch
	M	pylib/gyp/generator/make.py	View		4 chunks	+14 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 7 months ago (2011-05-27 21:48:31 UTC) #4

On 2011/05/27 21:45:54, Mark Mentovai wrote:
> Tracker bug?

Each time I think there is just "one last project".  Weird stuff that has broken
so far:
- the native client plugin (I had NACL off locally)
- the _pymodule thing (not built on the trybots(!) due to it deciding whether to
build at runtime)
- and this time, everything built and linked except for the v8 shell demo
(fffffuuuuuuu)

Expand Messages | Collapse Messages