Issue 7084037: Add commit_queue.py tool to toggle the bit of the commit queue from command line

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7084037: Add commit_queue.py tool to toggle the bit of the commit queue from command line (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add commit_queue.py tool to toggle the bit of the commit queue from command line Add "git cl set_commit" command to set the flag more easily. Add --commit to "git cl upload" to streamline workflow even more. Continue conversion to Rietveld object. R=dpranke@chromium.org BUG= TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Patch Set 3 : prefer --use-commit-queue #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -21 lines)			Patch
	A	commit_queue.py	View	1	1 chunk	+187 lines, -0 lines	0 comments	Download
	M	git_cl.py	View	1 2	7 chunks	+41 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 6 months ago (2011-05-30 20:06:37 UTC) #2

LGTM with the comments below.

http://codereview.chromium.org/7084037/diff/1/commit_queue.py
File commit_queue.py (right):

http://codereview.chromium.org/7084037/diff/1/commit_queue.py#newcode95
commit_queue.py:95: """Resets the commit bit."""
I might find 'clear' or 'unset' a little easier to remember than 'reset' (I get
confused as to whether reset == "clear" or "return to the default").

http://codereview.chromium.org/7084037/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/7084037/diff/1/git_cl.py#newcode918
git_cl.py:918: help='tell the commit queue to commit this patchset')
maybe --use_commit_queue instead? I would tend to think that --commit should
commit the issue immediately (which of course wouldn't make sense with --upload,
but still ...)

Expand Messages | Collapse Messages