Catch exception when register extension with inputUI.

Catch exception when register extension with inputUI.

BUG=Load virutal keyboard failed in desktop touchui build
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87334

[bryeung, 2011-05-30 15:29:27]

LGTM, from the logic side

I'm not sure about using globals this way though.

[James Hawkins, 2011-05-30 22:07:15]

http://codereview.chromium.org/7084033/diff/2001/chrome/browser/resources/key...
File chrome/browser/resources/keyboard/ime.js (right):

http://codereview.chromium.org/7084033/diff/2001/chrome/browser/resources/key...
chrome/browser/resources/keyboard/ime.js:197: if (!imeEnabled) {
Why is this check necessary since ImeUi is not created if
chrome.experimental.inputUI.register() throws an exception?

[Peng, 2011-05-31 14:55:34]

Hi James, I updated the code. Please review it again. Thanks.

http://codereview.chromium.org/7084033/diff/2001/chrome/browser/resources/key...
File chrome/browser/resources/keyboard/ime.js (right):

http://codereview.chromium.org/7084033/diff/2001/chrome/browser/resources/key...
chrome/browser/resources/keyboard/ime.js:197: if (!imeEnabled) {
On 2011/05/30 22:07:15, James Hawkins wrote:
> Why is this check necessary since ImeUi is not created if
> chrome.experimental.inputUI.register() throws an exception?

Done.

Remove all check code

[James Hawkins, 2011-05-31 16:38:16]

http://codereview.chromium.org/7084033/diff/7001/chrome/browser/resources/key...
File chrome/browser/resources/keyboard/ime.js (right):

http://codereview.chromium.org/7084033/diff/7001/chrome/browser/resources/key...
chrome/browser/resources/keyboard/ime.js:235: imeEnabled = false;
I really agree that using a separate global var for this is not ideal.  How
about setting imeui to null here and all of the existing checks should suffice? 
Yes, you may attempt to register inputUI in experimental again, but that should
be harmless.

[Peng, 2011-05-31 17:07:10]

On 2011/05/31 16:38:16, James Hawkins wrote:
>
http://codereview.chromium.org/7084033/diff/7001/chrome/browser/resources/key...
> File chrome/browser/resources/keyboard/ime.js (right):
> 
>
http://codereview.chromium.org/7084033/diff/7001/chrome/browser/resources/key...
> chrome/browser/resources/keyboard/ime.js:235: imeEnabled = false;
> I really agree that using a separate global var for this is not ideal.  How
> about setting imeui to null here and all of the existing checks should
suffice? 
> Yes, you may attempt to register inputUI in experimental again, but that
should
> be harmless.
I removed the global var. Please check it again. Thanks.

[James Hawkins, 2011-05-31 17:12:37]

LGTM, thanks.

[commit-bot: I haz the power, 2011-05-31 18:49:45]

Change committed as 87334