Add chrome://quota-internals/

webkit/quota/quota_manager.h

Index: webkit/quota/quota_manager.h
diff --git a/webkit/quota/quota_manager.h b/webkit/quota/quota_manager.h
index ee279aec76572c09b30d4b86446c3e60ba5b26f4..c1efa4bd35abc2bee342f9ced74679005a1b5905 100644
--- a/webkit/quota/quota_manager.h
+++ b/webkit/quota/quota_manager.h
@@ -30,6 +30,10 @@ class MessageLoopProxy;
 }
 class FilePath;
 
+namespace quota_internals {
+class QuotaInternalsProxy;
+}
+
 namespace quota {
 
 class QuotaDatabase;
@@ -73,7 +77,8 @@ class QuotaEvictionHandler {
 class QuotaManager : public QuotaTaskObserver,
                      public QuotaEvictionHandler,
                      public base::RefCountedThreadSafe<
-                         QuotaManager, QuotaManagerDeleter> {
+                         QuotaManager, QuotaManagerDeleter>,
+                     public base::SupportsWeakPtr<QuotaManager> {

[michaeln, 2011/05/30 19:36:57]

Is this really needed?

From the WebUI ctor, it looks like an instance is scoped to the life of an
individual tab (which will hold the profile open). And the
QuotaInternalsMessageHandler is scoped to the WebUI. And it looks like
QuotaInternalsHTMLSource instance is scoped to the Profile (although when do
they get removed?).

Seems like you could safely addref the quota_manager from within your UI handler
stuff.

I guess what i'm asking is, what are the lifecycles of these objects..
 QuotaInternalsUI
 QuotaInternalsMessageHandler 
 QuotaInternalsHTMLSource 

[tzik, 2011/05/31 04:53:01]

I'm sure that we can use scoped_ptr<QuotaManager> safely in
QuotaInternals{UI,MessageHandler,HTMLSource} as you say.
But I think, QuotaInternalsProxy is also owned by tasks made from
Run***On{IO,UI}Thread. So, QuotaInternalsProxy may have longer lifetime than
QuotaInternalsMessageHandler.
I'm afraid scoped_refptr in QuotaInternalsProxy expands the lifetime of
QuotaManager.
I'm not sure that causes no problem.

  public:
   typedef Callback3<QuotaStatusCode,
                     int64 /* usage */,
@@ -211,6 +216,7 @@ class QuotaManager : public QuotaTaskObserver,
   typedef std::map<HostAndType, UsageAndQuotaDispatcherTask*>
       UsageAndQuotaDispatcherTaskMap;
 
+  friend class quota_internals::QuotaInternalsProxy;
   friend struct QuotaManagerDeleter;
   friend class QuotaManagerProxy;
   friend class QuotaManagerTest;