Issue 7084023: Correctly set the length of string before creating filler object in the json parser (fixes crbug ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7084023: Correctly set the length of string before creating filler object in the json parser (fixes crbug ... (Closed)

Created:
9 years, 6 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Correctly set the length of string before creating filler object in the json parser (fixes crbug 84186). Testcase created based on the supplied test case from the bug report, but using json parse directly instead of through the chrome javascript console. Committed: http://code.google.com/p/v8/source/detail?r=8089

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	src/json-parser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-84186.js	View		1 chunk	+41 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-05-30 05:52:15 UTC) #2

LGTM

http://codereview.chromium.org/7084023/diff/1/test/mjsunit/regress/regress-cr...
File test/mjsunit/regress/regress-crbug-84186.js (right):

http://codereview.chromium.org/7084023/diff/1/test/mjsunit/regress/regress-cr...
test/mjsunit/regress/regress-crbug-84186.js:28: // Test that the expected string
is parsed in the json parser when the lenght
length

Expand Messages | Collapse Messages