Issue 7084022: views: Paint frame of maximized incognito app & popup windows with incognito color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7084022: views: Paint frame of maximized incognito app & popup windows with incognito color. (Closed)

Created:
9 years, 6 months ago by Satoshi.Matsuzaki

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan, mirandac

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

views: Paint frame of maximized incognito app & popup windows with incognito color. BUG=37501 TEST=Manual, see bug.

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/frame/opaque_browser_frame_view.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Satoshi.Matsuzaki

Hello, could you please review this for me? This is follow-up of http://codereview.chromium.org/606060 .

9 years, 6 months ago (2011-05-29 17:12:26 UTC) #1

Miranda Callahan

On 2011/05/29 17:12:26, Satoshi.Matsuzaki wrote: > Hello, could you please review this for me? > ...

9 years, 6 months ago (2011-05-31 19:02:10 UTC) #2

Satoshi.Matsuzaki

Thanks for your review, Miranda. BTW, I can't send this CL to tryserver because I'm ...

9 years, 6 months ago (2011-06-01 12:32:59 UTC) #3

mirandac

9 years, 6 months ago (2011-06-06 13:31:10 UTC) #4

Hi, Satoshi --

yes, I'll do that -- sorry I didn't answer earlier, the sorting
algorithm marked this email as spam! :-(

- Miranda

On Wed, Jun 1, 2011 at 08:32,  <Satoshi.Matsuzaki@gmail.com> wrote:
> Thanks for your review, Miranda.
>
> BTW, I can't send this CL to tryserver because I'm not a committer.
> (Authentication in "gcl try" fails)
> So could you please commit this CL for me? I've signed to CLA already.
> Thank you in advance.
>
> http://codereview.chromium.org/7084022/
>

Expand Messages | Collapse Messages