Issue 7084007: Adds URLRequestJob bytes read to NetLog.

Issue 7084007: Adds URLRequestJob bytes read to NetLog. (Closed)

Created:
9 years, 7 months ago by mmenke

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, eroman

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds URLRequestJob bytes read to NetLog. Also no longer include raw bytes for 0-length transfers. BUG=81003 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87528

Patch Set 2 : PassiveLogCollector changes #

Patch Set 3 : sync #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -90 lines)			Patch
M	chrome/browser/net/passive_log_collector.cc	View	1 2	2 chunks	+7 lines, -1 line	1 comment	Download
M	net/base/net_log.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/base/net_log.cc	View	1 2	2 chunks	+47 lines, -0 lines	0 comments	Download
M	net/base/net_log_event_type_list.h	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_mac.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/socket/ssl_client_socket_openssl.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/socket/ssl_client_socket_win.cc	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/socket/stream_socket.h	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/socket/stream_socket.cc	View	1 2	2 chunks	+0 lines, -49 lines	0 comments	Download
M	net/socket/tcp_client_socket_libevent.cc	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	net/socket/tcp_client_socket_win.cc	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	net/url_request/url_request_job.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mmenke

I'm not logging the new messages when byte logging is disabled to cut down a ...

9 years, 7 months ago (2011-05-27 22:17:46 UTC) #1

eroman

Will review as soon as I finish my interview :) Was actually away on vacation ...

9 years, 6 months ago (2011-06-01 18:51:50 UTC) #3

eroman

LGTM http://codereview.chromium.org/7084007/diff/21001/chrome/browser/net/passive_log_collector.cc File chrome/browser/net/passive_log_collector.cc (right): http://codereview.chromium.org/7084007/diff/21001/chrome/browser/net/passive_log_collector.cc#newcode427 chrome/browser/net/passive_log_collector.cc:427: entry.type == net::NetLog::TYPE_SSL_SOCKET_BYTES_SENT || good spot!

9 years, 6 months ago (2011-06-01 19:27:01 UTC) #4

mmenke

Thanks. Forgot to update the passive log collector myself, which is what made me check ...

9 years, 6 months ago (2011-06-01 19:29:29 UTC) #5

commit-bot: I haz the power

Try job failure for 7084007-21001 on linux_clang for step compile: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=1956

9 years, 6 months ago (2011-06-01 20:12:40 UTC) #6

Change committed as 87528

Expand Messages | Collapse Messages