Issue 7082038: Fix memory leak of base/i18n/time_formatter.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7082038: Fix memory leak of base/i18n/time_formatter.cc (Closed)

Created:
9 years, 6 months ago by kinaba

Modified:
9 years, 6 months ago

Reviewers:
brettw, kochi

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix memory leak of base/i18n/time_formatter.cc This patch fixes the leak exposed by the newly added unittests in http://src.chromium.org/viewvc/chrome?view=rev&revision=87229. BUG=None TEST=base_unittests: TimeFormattingTest.TimeFormatTimeOfDayDefault12h Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87234

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/i18n/time_formatting.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

kochi

On 2011/05/30 12:53:24, Takayoshi Kochi wrote: > LGTM Please update the description to be more ...

9 years, 6 months ago (2011-05-30 12:56:15 UTC) #3

LGTM