Issue 7082029: Use m['approval'] instead of looking at the text for 'lgtm'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7082029: Use m['approval'] instead of looking at the text for 'lgtm'. (Closed)

Created:
9 years, 7 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Use m['approval'] instead of looking at the text for 'lgtm'. This makes it coherent with the commit queue by keeping the lgtm at a single place. This simplifies owners check code. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87251

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -73 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+8 lines, -50 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		2 chunks	+12 lines, -23 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM. Nice to see this get consolidated.